Repository navigation
fix(otel): build against OpenTelemetry v1.45 and otel/log v0.21 - #68
Merged
Merged
Conversation
otel/log v0.21 dropped its own KeyValue and Value types for attribute.KeyValue and attribute.Value, so the otel, grpc and rest packages stopped compiling for any consumer that raised otel/sdk/log to the release fixing GO-2026-6615.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #67 to the frozen v2 line, as an emergency patch.
Why
go.opentelemetry.io/otel/logv0.21.0 replacedlog.KeyValue/log.Valuewithattribute.KeyValue/attribute.Value. v2.13.1 uses the old API, so any build that also containsotel/sdk/logv0.21.0 — the release fixing GO-2026-6615 — fails to compilepkg/v2/otel. Consumers still reach v2 throughgo-wf/v2.What
otel,otel/sdk,otel/metric,otel/trace,otel/sdk/metricto v1.45.0 andotel/log,otel/sdk/log,otlploghttpto v0.21.0.otel,grpc,restand the otel logging example to theattributepackage. No exported signature changes.attribute.Value.AsInterface().golang.org/x/netrises to v0.57.0, which deprecateshttp2/h2c;grpc/server.gokeeps it under//nolint:staticcheck.Release
This branch has no automated release; tag
v2.13.2by hand after merging.Verification
task ci:checkpasses locally (unit tests with race detector, lint).go vetover the tagged examples reports only findings that predate this change.