Repository navigation
Unify chart calculation and align README with Wasm-first engine - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chart callers currently choose between three entry points with different result contracts. This change replaces them with
calculate_chart(&ephemeris, ChartInput), requiring explicit zodiac settings inChartInput.zodiacand returning one richChartValuescontract. The README now leads with the Wasm-first repository description and gives browser, Worker, and native integrations prominent links.Validation: workspace tests and Clippy; both Wasm adapter builds and Clippy checks; runtime boundary and usage-policy checks; package verification; native examples; documentation links and README/example synchronization; migration negative controls. Native and Wasm convention replays each pass 440 charts and reject 16 overlapping sets. Local workerd replay passes 3,831 matrix cases, 58 event cases, and 40 HTTP cases with only the documented migration exceptions. Chrome smoke checks pass for Tropical, Fagan–Bradley Whole Sign, and True Sky constellation charts. Independent spec and standards reviews found no blocking issues.
Rebased onto current main, preserving licensing/notices, CI selection, and ephemeris extraction. Checks establish regression and local runtime behavior; no hosted deployment, dataset regeneration, or independent astronomical validation was performed.