You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@paulhovey thanks for the PR! I'd really like to see a solution here doesn't require a new field for such a specific usage. Can the need for "cone" be inferred at all? Would always passing --no-cone work for the majority of cases? Please discuss further on the issues if needed.
Hi Jace, understood about not wanting to introduce a new config option, but I'm not sure a better way off the top of my head. Using --no-cone is not recommended, so I think staying with the default is what gitman should be doing: https://git-scm.com/docs/git-sparse-checkout#_internalsnon_cone_problems
However, some people may have a specific reason for needing --no-cone, and this would enable them. I'll think on this a little more, but an extra toggle might be the only way to do this, since I don't think it can be strictly inferred.
Thanks for pulling the regex into a separate PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this should resolve #360 and #363 . It exposes a
sparse_paths_typewhich will pass--coneor --no-cone` to git.It also updates the regex package, as mentioned in #363 .
I'm open to any feedback on this, I'm just someone with the same issue and access to GLM-5.2 🙂