Skip to content

Detect available glibc and musl runtimes - #2975

Merged
j178 merged 2 commits into
mainfrom
libc
Oct 30, 2026
Merged

j178 merged 2 commits into
mainfrom
libc

Conversation

@j178

@j178 j178 commented Oct 30, 2026

Copy link
Copy Markdown
Owner

Add a shared libc detector using standard loader paths, including legacy glibc loaders and musl alongside gcompat. Prefer glibc when both are available and report unrecognized Linux environments explicitly.

This adds the detection helper for subsequent toolchain installer integration.

Copilot AI balanced review requested due to automatic review settings October 30, 2026 02:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T03:43:09.027703Z d1abc1d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@j178 j178 added the internal Internal changes label Oct 30, 2026 — with ChatGPT Codex Connector
@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.62963% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.21%. Comparing base (08098ac) to head (d1abc1d).

Files with missing lines Patch % Lines
crates/prek/src/libc.rs 89.62% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2975      +/-   ##
==========================================
- Coverage   94.23%   94.21%   -0.02%     
==========================================
  Files         147      148       +1     
  Lines       31286    31421     +135     
==========================================
+ Hits        29482    29603     +121     
- Misses       1804     1818      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prek-ci-bot

prek-ci-bot Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

📦 Cargo Bloat Comparison

Build: profiling + self-update (with debug info).

Metric Base (bytes) Head (bytes) Change
.text 12,908,656 12,908,656 +0 (+0.00%)
File 273,227,688 273,169,576 -58,112 (-0.02%)
Largest symbol changes

Increases

Symbol Base (bytes) Head (bytes) Change (bytes)
<tracing_subscriber::fmt::format::Format as tracing_subscriber::fmt::format::FormatEvent<tracing_subscriber::registry::sharded::Registry, tracing_subscriber::fmt::format::DefaultFields>>::format_event 5,861 5,893 +32
<prek::languages::ruby::installer::RubyInstaller>::download::{closure#0} 18,718 18,732 +14

Decreases

Symbol Base (bytes) Head (bytes) Change (bytes)
<tracing_subscriber::layer::context::Context<tracing_subscriber::layer::layered::Layered<tracing_subscriber::filter::layer_filters::Filtered<tracing_subscriber::fmt::fmt_layer::Layer<tracing_subscriber::registry::sharded::Registry, tracing_… 454 405 -49

@prek-ci-bot

prek-ci-bot Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 1 improvements above the 10% threshold.

Environment
  • OS: Linux 7.0.0-1017-azure
  • CPU: 4 cores
  • prek version: prek 0.5.7+38 (ca9e202 2026-10-30)
  • Rust version: rustc 1.99.1 (58cf8f9c3 2026-10-13)
  • Hyperfine version: hyperfine 2.0.0
CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command Mean Wall Time [ms] Change Factor
prek-base --version 2.5 ± 0.1
prek-head --version 2.4 ± 0.1 -4.8%

prek list

Command Mean Wall Time [ms] Change Factor
prek-base list 10.3 ± 0.6
prek-head list 9.9 ± 1.2 -4.0%

prek validate-config .pre-commit-config.yaml

⏭️ Skipped: .pre-commit-config.yaml not found

prek sample-config

Command Mean Wall Time [ms] Change Factor
prek-base sample-config 3.0 ± 0.5
prek-head sample-config 2.8 ± 0.1 -7.0%
Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command Mean Wall Time [ms] Change Factor
prek-base run --all-files 18.5 ± 0.5
prek-head run --all-files 18.4 ± 0.8 -0.8%

prek run --all-files (warm - with cache)

Command Mean Wall Time [ms] Change Factor
prek-base run --all-files 18.7 ± 0.4
prek-head run --all-files 18.7 ± 0.4 -0.1%
Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command Mean Wall Time [ms] Change Factor
prek-base run --all-files 18.8 ± 0.8
prek-head run --all-files 18.5 ± 0.7 -1.5%
Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command Mean Wall Time [ms] Change Factor
prek-base run trailing-whitespace --all-files 9.5 ± 0.3
prek-head run trailing-whitespace --all-files 9.0 ± 0.2 -4.4%

prek run end-of-file-fixer --all-files

Command Mean Wall Time [ms] Change Factor
prek-base run end-of-file-fixer --all-files 8.6 ± 0.2
prek-head run end-of-file-fixer --all-files 8.2 ± 0.2 -5.4%

prek run check-json --all-files

Command Mean Wall Time [ms] Change Factor
prek-base run check-json --all-files 8.4 ± 2.5
prek-head run check-json --all-files 7.4 ± 0.2 -11.9%

✅ Performance improvement for prek run check-json --all-files: 11.8700% faster

prek run check-yaml --all-files

Command Mean Wall Time [ms] Change Factor
prek-base run check-yaml --all-files 7.9 ± 0.2
prek-head run check-yaml --all-files 7.5 ± 0.2 -5.0%

prek run check-toml --all-files

Command Mean Wall Time [ms] Change Factor
prek-base run check-toml --all-files 7.6 ± 0.1
prek-head run check-toml --all-files 7.4 ± 0.3 -1.9%

prek run check-xml --all-files

Command Mean Wall Time [ms] Change Factor
prek-base run check-xml --all-files 7.7 ± 0.2
prek-head run check-xml --all-files 7.4 ± 0.2 -4.8%

prek run detect-private-key --all-files

Command Mean Wall Time [ms] Change Factor
prek-base run detect-private-key --all-files 8.1 ± 0.2
prek-head run detect-private-key --all-files 7.8 ± 0.8 -4.2%

prek run fix-byte-order-marker --all-files

Command Mean Wall Time [ms] Change Factor
prek-base run fix-byte-order-marker --all-files 8.2 ± 0.2
prek-head run fix-byte-order-marker --all-files 7.8 ± 0.2 -4.0%
Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command Mean Wall Time [ms] Change Factor
prek-base install-hooks 5.4 ± 0.2
prek-head install-hooks 4.9 ± 0.1 -8.9%

prek install-hooks (warm - with cache)

Command Mean Wall Time [ms] Change Factor
prek-base install-hooks 5.3 ± 0.5
prek-head install-hooks 4.8 ± 0.1 -9.8%
File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command Mean Wall Time [ms] Change Factor
prek-base run 11.3 ± 0.2
prek-head run 11.4 ± 1.1 +0.4%

prek run --files '*.json' (specific file type)

Command Mean Wall Time [ms] Change Factor
prek-base run --files '*.json' 5.9 ± 0.1
prek-head run --files '*.json' 5.6 ± 0.1 -4.3%
Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command Mean Wall Time [ms] Change Factor
prek-base run --dry-run --all-files 7.7 ± 0.3
prek-head run --dry-run --all-files 7.3 ± 0.1 -4.5%
Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command Mean Wall Time [ms] Change Factor
prek-base run check-hooks-apply --all-files 8.9 ± 0.1
prek-head run check-hooks-apply --all-files 8.9 ± 0.5 -0.4%

prek run check-useless-excludes --all-files

Command Mean Wall Time [ms] Change Factor
prek-base run check-useless-excludes --all-files 9.1 ± 0.5
prek-head run check-useless-excludes --all-files 8.8 ± 0.2 -2.9%

prek run identity --all-files

Command Mean Wall Time [ms] Change Factor
prek-base run identity --all-files 8.0 ± 0.3
prek-head run identity --all-files 7.7 ± 0.3 -3.6%

Copilot AI balanced review requested due to automatic review settings October 30, 2026 03:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@j178
j178 merged commit 69b23d8 into main Oct 30, 2026
37 checks passed
@j178
j178 deleted the libc branch October 30, 2026 04:29
@j178
j178 restored the libc branch October 30, 2026 04:35
@j178
j178 deleted the libc branch October 30, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants