Add `normalize-indentation` builtin hook by tchernobog · Pull Request #2967 · j178/prek

tchernobog · 2026-10-27T00:03:25Z

Adds a normalize-indentation builtin hook that converts leading indentation to spaces or tabs, with --indent, --tab-size and --check. This is useful due to many developers preferring one format over the other in their editor of choice, and a project needing to enforce a common style.

chatgpt-codex-connector · 2026-10-27T00:03:33Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-28T14:21:37.551518Z We couldn’t complete this review. Comment `@codex review` to try again.	`380a610`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

tchernobog · 2026-10-27T00:08:34Z

I saw something close was recently added in commit 0cd15be. I hadn't seen that yet, but I wanted to create the PR anyway because this does a bit more than expand-tabs: it can convert both ways (for projects that want tabs over spaces too). We can close this PR if unwanted, or we can decide to favor this one over the other.

codecov · 2026-10-27T00:13:18Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.23%. Comparing base (aa757d3) to head (380a610).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2967      +/-   ##
==========================================
+ Coverage   94.18%   94.23%   +0.04%     
==========================================
  Files         146      147       +1     
  Lines       31024    31286     +262     
==========================================
+ Hits        29220    29481     +261     
- Misses       1804     1805       +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Convert the leading indentation of non-blank lines to spaces or tabs, with --indent, --tab-size and --check. Line endings, a UTF-8 BOM and the final newline state are preserved, and --check stops at the first violation. Co-authored-by: Copilot

prek-ci-bot · 2026-10-27T00:33:12Z

📦 Cargo Bloat Comparison

Build: profiling + self-update (with debug info).

Metric	Base (bytes)	Head (bytes)	Change
`.text`	12,945,712	12,908,656	-37,056 (-0.29%)
File	272,374,832	273,227,688	+852,856 (+0.31%)

Largest symbol changes

Increases

Symbol	Base (bytes)	Head (bytes)	Change (bytes)
`prek::archive::unzip::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}`	105,577	126,371	+20,794
`prek::cli::hook_impl::hook_run_options::{closure#0}`	0	20,063	+20,063
`<prek::languages::deno::installer::DenoInstaller>::download::{closure#0}`	0	20,057	+20,057
`<toml::de::deserializer::value::ValueDeserializer as serde_core::de::Deserializer>::deserialize_any::<<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor>`	0	18,966	+18,966
`<prek::workspace::Project>::build_hooks::{closure#0}::{closure#0}::{closure#0}::<i16>`	18,101	34,295	+16,194
`<prek::cli::GlobalArgs as clap_builder::derive::Args>::augment_args`	0	13,279	+13,279
`<prek::config::repo::Repo as serde_core::de::Deserialize>::deserialize::<toml::de::deserializer::value::ValueDeserializer>`	0	13,002	+13,002
`<prek::languages::deno::deno::Deno as prek::languages::LanguageBackend>::install::{closure#0}`	4,108	16,372	+12,264
`<tokio_tar::entry::EntryFields<tokio_tar::archive::Archive<async_compression::tokio::bufread::GzipDecoder<tokio::io::util::buf_reader::BufReader<fs_err::tokio::file::File>>>>>::unpack::{closure#0}`	83,578	95,746	+12,168
`prek::run::{closure#0}`	50,806	60,483	+9,677

Decreases

Symbol	Base (bytes)	Head (bytes)	Change (bytes)
`prek::cli::hook_impl::hook_impl::{closure#0}`	28,009	0	-28,009
`<prek::languages::deno::installer::DenoInstaller>::install::{closure#0}`	27,214	0	-27,214
`prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}`	76,827	50,878	-25,949
`<prek::cli::UpdateArgs as clap_builder::derive::Args>::augment_args`	24,337	0	-24,337
`<toml::de::deserializer::Deserializer as serde_core::de::Deserializer>::deserialize_any::<<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor>`	18,398	0	-18,398
`<prek::cli::Cli as clap_builder::derive::CommandFactory>::command`	19,269	945	-18,324
`<prek::hook::Hook>::from_spec::{closure#0}`	33,030	16,177	-16,853
`<tokio_tar::entry::EntryFields<tokio_tar::archive::Archive<async_compression::tokio::bufread::GzipDecoder<tokio::io::util::buf_reader::BufReader<fs_err::tokio::file::File>>>>>::unpack_in::{closure#0}`	15,419	0	-15,419
`<prek::cli::RunOptions as clap_builder::derive::Args>::augment_args`	41,525	30,965	-10,560
`<prek::languages::pygrep::pygrep::Error as serde_core::de::Deserialize>::deserialize::<&mut serde_json::de::Deserializer<serde_json::read::StrRead>>`	7,943	1,659	-6,284

prek-ci-bot · 2026-10-27T00:33:13Z

⚡️ Hyperfine Benchmarks

Summary: 2 regressions, 0 improvements above the 10% threshold.

Environment

OS: Linux 6.17.0-1022-azure
CPU: 4 cores
prek version: prek 0.5.7+38 (497e169 2026-10-28)
Rust version: rustc 1.99.1 (58cf8f9c3 2026-10-13)
Hyperfine version: hyperfine 2.0.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base --version`	1.8 ± 0.1
`prek-head --version`	1.8 ± 0.1	-0.2%

`prek list`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base list`	7.6 ± 0.2
`prek-head list`	7.8 ± 0.2	+2.5%

`prek validate-config .pre-commit-config.yaml`

⏭️ Skipped: .pre-commit-config.yaml not found

`prek sample-config`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base sample-config`	2.2 ± 0.1
`prek-head sample-config`	2.3 ± 0.6	+7.1%

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run --all-files`	14.6 ± 0.3
`prek-head run --all-files`	14.6 ± 0.4	+0.2%

`prek run --all-files (warm - with cache)`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run --all-files`	14.8 ± 0.4
`prek-head run --all-files`	14.4 ± 0.3	-2.4%

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run --all-files`	14.6 ± 0.3
`prek-head run --all-files`	14.4 ± 0.3	-1.3%

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run trailing-whitespace --all-files`	7.3 ± 0.2
`prek-head run trailing-whitespace --all-files`	7.5 ± 1.5	+3.7%

`prek run end-of-file-fixer --all-files`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run end-of-file-fixer --all-files`	6.4 ± 0.1
`prek-head run end-of-file-fixer --all-files`	6.4 ± 0.1	+0.4%

`prek run check-json --all-files`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run check-json --all-files`	5.6 ± 0.1
`prek-head run check-json --all-files`	6.1 ± 2.8	+8.2%

`prek run check-yaml --all-files`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run check-yaml --all-files`	5.7 ± 0.1
`prek-head run check-yaml --all-files`	5.9 ± 0.9	+2.8%

`prek run check-toml --all-files`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run check-toml --all-files`	5.8 ± 0.9
`prek-head run check-toml --all-files`	5.9 ± 1.2	+1.9%

`prek run check-xml --all-files`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run check-xml --all-files`	5.6 ± 0.1
`prek-head run check-xml --all-files`	5.7 ± 0.1	+1.0%

`prek run detect-private-key --all-files`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run detect-private-key --all-files`	6.0 ± 0.1
`prek-head run detect-private-key --all-files`	6.0 ± 0.1	+0.2%

`prek run fix-byte-order-marker --all-files`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run fix-byte-order-marker --all-files`	6.4 ± 1.9
`prek-head run fix-byte-order-marker --all-files`	6.2 ± 0.2	-2.1%

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base install-hooks`	3.8 ± 0.1
`prek-head install-hooks`	3.8 ± 0.1	+1.7%

`prek install-hooks (warm - with cache)`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base install-hooks`	3.8 ± 0.1
`prek-head install-hooks`	3.8 ± 0.1	+1.1%

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run`	9.0 ± 0.6
`prek-head run`	8.9 ± 0.2	-1.4%

`prek run --files '*.json' (specific file type)`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run --files '*.json'`	4.5 ± 0.1
`prek-head run --files '*.json'`	9.5 ± 21.7	+112.8%	(2.1x slower)

⚠️ Warning: Performance regression for prek run --files '*.json' (specific file type): 112.7700% slower

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run --dry-run --all-files`	5.9 ± 0.1
`prek-head run --dry-run --all-files`	6.8 ± 3.9	+16.0%

⚠️ Warning: Performance regression for prek run --dry-run --all-files (measures init overhead): 16.0200% slower

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run check-hooks-apply --all-files`	7.2 ± 0.2
`prek-head run check-hooks-apply --all-files`	7.4 ± 0.6	+2.8%

`prek run check-useless-excludes --all-files`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run check-useless-excludes --all-files`	7.3 ± 0.1
`prek-head run check-useless-excludes --all-files`	7.4 ± 0.2	+1.7%

`prek run identity --all-files`

Command	Mean Wall Time [ms]	Change	Factor
`prek-base run identity --all-files`	6.3 ± 0.1
`prek-head run identity --all-files`	6.3 ± 0.1	-0.3%

j178 · 2026-10-28T14:20:22Z

@codex review

chatgpt-codex-connector · 2026-10-28T14:21:37Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

j178 · 2026-10-28T14:23:32Z

Thanks!

tchernobog requested a review from j178 as a code owner October 27, 2026 00:03

tchernobog force-pushed the normalize-indentation branch from cd89012 to 6f08ed2 Compare October 27, 2026 00:10

Add normalize-indentation builtin hook

fe3d72d

Convert the leading indentation of non-blank lines to spaces or tabs, with --indent, --tab-size and --check. Line endings, a UTF-8 BOM and the final newline state are preserved, and --check stops at the first violation. Co-authored-by: Copilot

tchernobog force-pushed the normalize-indentation branch from 6f08ed2 to fe3d72d Compare October 27, 2026 00:16

j178 changed the title ~~Add normalize-indentation builtin hook~~ Add normalize-indentation builtin hook Oct 28, 2026

j178 added the enhancement New feature or request label Oct 28, 2026

j178 added 2 commits October 28, 2026 22:03

Merge main into normalize-indentation

f5b3721

Simplify indentation normalization

380a610

j178 merged commit 08098ac into j178:main Oct 28, 2026
69 of 71 checks passed

BrewTestBot mentioned this pull request Oct 30, 2026

prek 0.5.9 Homebrew/homebrew-core#322316

Merged

Conversation

tchernobog commented Oct 27, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

tchernobog commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

prek-ci-bot Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Cargo Bloat Comparison

Increases

Decreases

Uh oh!

prek-ci-bot Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

j178 commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

Uh oh!

Uh oh!

j178 commented Oct 28, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chatgpt-codex-connector Bot commented Oct 27, 2026 •

edited

Loading

tchernobog commented Oct 27, 2026 •

edited

Loading

codecov Bot commented Oct 27, 2026 •

edited

Loading

prek-ci-bot Bot commented Oct 27, 2026 •

edited

Loading

prek-ci-bot Bot commented Oct 27, 2026 •

edited

Loading

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek run detect-private-key --all-files`

`prek run fix-byte-order-marker --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`