Repository navigation
Report precise cargo-bloat sizes and symbol changes - #2963
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2963 +/- ##
==========================================
+ Coverage 94.15% 94.20% +0.04%
==========================================
Files 147 147
Lines 31160 31109 -51
==========================================
- Hits 29339 29305 -34
+ Misses 1821 1804 -17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat ComparisonBuild:
Largest symbol changesIncreasesNone. DecreasesNone. |
⚡️ Hyperfine BenchmarksSummary: 0 regressions, 2 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base --version |
2.5 ± 0.2 | ||
prek-head --version |
2.2 ± 0.1 | -13.0% |
✅ Performance improvement for prek --version: 13.0200% faster
prek list
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base list |
9.9 ± 1.2 | ||
prek-head list |
9.7 ± 0.4 | -2.2% |
prek validate-config .pre-commit-config.yaml
⏭️ Skipped: .pre-commit-config.yaml not found
prek sample-config
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base sample-config |
2.8 ± 0.5 | ||
prek-head sample-config |
2.6 ± 0.2 | -8.5% |
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run --all-files |
18.7 ± 0.6 | ||
prek-head run --all-files |
18.2 ± 0.8 | -2.4% |
prek run --all-files (warm - with cache)
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run --all-files |
18.5 ± 0.4 | ||
prek-head run --all-files |
18.6 ± 3.1 | +0.8% |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run --all-files |
18.5 ± 0.6 | ||
prek-head run --all-files |
17.8 ± 0.5 | -3.4% |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run trailing-whitespace --all-files |
8.8 ± 0.3 | ||
prek-head run trailing-whitespace --all-files |
8.6 ± 0.3 | -3.0% |
prek run end-of-file-fixer --all-files
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
7.9 ± 0.1 | ||
prek-head run end-of-file-fixer --all-files |
8.0 ± 0.3 | +1.1% |
prek run check-json --all-files
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run check-json --all-files |
7.1 ± 1.1 | ||
prek-head run check-json --all-files |
7.1 ± 0.6 | -0.7% |
prek run check-yaml --all-files
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run check-yaml --all-files |
7.5 ± 0.1 | ||
prek-head run check-yaml --all-files |
7.0 ± 0.2 | -6.5% |
prek run check-toml --all-files
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run check-toml --all-files |
7.0 ± 0.1 | ||
prek-head run check-toml --all-files |
7.0 ± 0.3 | -0.9% |
prek run check-xml --all-files
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run check-xml --all-files |
7.1 ± 0.5 | ||
prek-head run check-xml --all-files |
6.8 ± 0.1 | -4.4% |
prek run detect-private-key --all-files
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run detect-private-key --all-files |
8.3 ± 2.3 | ||
prek-head run detect-private-key --all-files |
7.1 ± 0.2 | -13.8% |
✅ Performance improvement for prek run detect-private-key --all-files: 13.7900% faster
prek run fix-byte-order-marker --all-files
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
7.5 ± 0.3 | ||
prek-head run fix-byte-order-marker --all-files |
7.3 ± 0.2 | -2.2% |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base install-hooks |
4.7 ± 0.1 | ||
prek-head install-hooks |
4.5 ± 0.0 | -3.9% |
prek install-hooks (warm - with cache)
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base install-hooks |
4.7 ± 0.1 | ||
prek-head install-hooks |
4.5 ± 0.0 | -4.5% |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run |
10.5 ± 0.1 | ||
prek-head run |
10.5 ± 0.1 | +0.1% |
prek run --files '*.json' (specific file type)
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run --files '*.json' |
5.3 ± 0.1 | ||
prek-head run --files '*.json' |
5.2 ± 0.2 | -2.2% |
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run --dry-run --all-files |
7.1 ± 0.2 | ||
prek-head run --dry-run --all-files |
6.9 ± 0.3 | -3.5% |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run check-hooks-apply --all-files |
8.4 ± 0.3 | ||
prek-head run check-hooks-apply --all-files |
8.1 ± 0.2 | -4.0% |
prek run check-useless-excludes --all-files
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run check-useless-excludes --all-files |
8.4 ± 0.3 | ||
prek-head run check-useless-excludes --all-files |
8.2 ± 0.4 | -1.5% |
prek run identity --all-files
| Command | Mean Wall Time [ms] | Change | Factor |
|---|---|---|---|
prek-base run identity --all-files |
7.1 ± 0.1 | ||
prek-head run identity --all-files |
7.3 ± 0.4 | +1.7% |
Calculate size changes from raw JSON, report the largest symbol changes, and retain complete data for investigation.