Skip to content

fix(rendering): prevent oversized Gaussian splats from obscuring close-up views #7610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShineSea wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

fix(rendering): prevent oversized Gaussian splats from obscuring close-up views #7610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cpp/open3d/visualization/rendering/gaussian_splat/shaders/gaussian_project.comp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,18 +326,22 @@ SortEntryParams ProjectGaussian(uint splat_index) {
view_params.clip_from_view[1].w,
view_params.clip_from_view[2].w);

float inv_w_sq = 1.0 / (clip_center.w * clip_center.w);
vec4 jac_clip = clip_center;
jac_clip.xy = clamp(jac_clip.xy,
vec2(-1.3) * jac_clip.w,
vec2(1.3) * jac_clip.w);
float inv_w_sq = 1.0 / (jac_clip.w * jac_clip.w);
vec2 resolution = GetViewportSize();
vec3 jacobian_x = 0.5 * resolution.x *
(clip_row0 * clip_center.w - clip_row3 * clip_center.x) *
(clip_row0 * jac_clip.w - clip_row3 * jac_clip.x) *
inv_w_sq;
// Match the projected 2D covariance to the output image's Y convention.
// OpenGL images use Y increasing upward; Metal/output textures use Y=0 at
// the top. The sign must match the pixel coordinate system consumed later
// by the composite shader.
float y_sign = GetScreenYDown() ? -1.0 : 1.0;
vec3 jacobian_y = y_sign * 0.5 * resolution.y *
(clip_row1 * clip_center.w - clip_row3 * clip_center.y) *
(clip_row1 * jac_clip.w - clip_row3 * jac_clip.y) *
inv_w_sq;

vec3 cov_jx = covariance_view * jacobian_x;
Expand Down