Repository navigation
Isirmt/16 3 - #10
Isirmt/16 3#10
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f12245e1ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export async function GET(_req: NextRequest, context: { params: Promise<{ slug: string[] }> }) { | ||
| const slug = decodeURIComponent((await context.params).slug.join('/')); | ||
| const { data, font: fontBase64, base64Image } = await getImageData(slug); |
There was a problem hiding this comment.
Cache the generated OGP response, not only its inputs
For direct requests to this dynamic OGP route, the new cache scope ends when getImageData() returns, so every cache hit still rebuilds the buffer and, for posts without a thumbnail, reruns the comparatively expensive ImageResponse rendering. The removed route-level revalidate = 1200 previously cached the completed response; preserve that behavior by caching the rendered bytes or adding equivalent response/CDN caching headers.
Useful? React with 👍 / 👎.
No description provided.