Skip to content

Isirmt/16 3 - #10

Merged
isirmt merged 3 commits into
mainfrom
isirmt/16-3
Aug 8, 2026
Merged

isirmt merged 3 commits into
mainfrom
isirmt/16-3

Conversation

@isirmt

@isirmt isirmt commented Aug 8, 2026

Copy link
Copy Markdown
Owner

No description provided.

@vercel

vercel Bot commented Aug 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
isirmt-tech Ready Ready Preview Aug 8, 2026 4:56am

Request Review

@isirmt
isirmt merged commit 26e7af9 into main Aug 8, 2026
4 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f12245e1ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +24 to +26
export async function GET(_req: NextRequest, context: { params: Promise<{ slug: string[] }> }) {
const slug = decodeURIComponent((await context.params).slug.join('/'));
const { data, font: fontBase64, base64Image } = await getImageData(slug);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Cache the generated OGP response, not only its inputs

For direct requests to this dynamic OGP route, the new cache scope ends when getImageData() returns, so every cache hit still rebuilds the buffer and, for posts without a thumbnail, reruns the comparatively expensive ImageResponse rendering. The removed route-level revalidate = 1200 previously cached the completed response; preserve that behavior by caching the rendered bytes or adding equivalent response/CDN caching headers.

Useful? React with 👍 / 👎.

This branch was successfully deployed

1 active deployment
Preview — f12245e1 Deployed Aug 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant