Add per-VNI multisite ingress replication (Cisco NX-OS) - #577
Merged
Merged
Conversation
adamtrizuljak-sap
force-pushed
the
feat/nve-multisite-ingress-repl
branch
from
September 18, 2026 08:35
aa68674 to
729a3f7
Compare
adamtrizuljak-sap
force-pushed
the
feat/nve-multisite-ingress-repl
branch
from
September 18, 2026 08:46
729a3f7 to
7ca72f8
Compare
adamtrizuljak-sap
marked this pull request as ready for review
September 18, 2026 08:52
adamtrizuljak-sap
force-pushed
the
feat/nve-multisite-ingress-repl
branch
from
September 22, 2026 15:37
7ca72f8 to
a79c024
Compare
adamtrizuljak-sap
force-pushed
the
feat/nve-multisite-ingress-repl
branch
from
September 23, 2026 09:03
a79c024 to
994c9f4
Compare
felix-kaestner
approved these changes
Sep 23, 2026
…ecific configuration MultisiteIngressReplication does not have direct support in Openconfig -> we make it provider-specific configuration Signed-off-by: Adam Trizuljak <adam.trizuljak@sap.com>
adamtrizuljak-sap
force-pushed
the
feat/nve-multisite-ingress-repl
branch
from
September 23, 2026 12:13
994c9f4 to
38009cb
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for per-VNI multisite ingress replication on Border Gateway (BGW) nodes. Because this is a Cisco NX-OS–specific feature with no OpenConfig equivalent, it is exposed through a new provider-specific configuration resource,
EVPNInstanceConfig, rather than on the vendor-neutral core API.When enabled, BUM traffic for a VNI is replicated to remote VTEP peers in the multisite domain via ingress replication. Three modes are supported:
Disabled(default),Enabled, andEnabledOptimized.This maps to the NX-OS CLI:
and the YANG leaf
multisiteIngReplat:multisiteIngRepl: Enabledrequiresevpn multisite border-gatewayto be enabled, which is not yet supported in network-operator. See the Testing section for details. This PR is a pre-requisite for supportingevpn multisite border-gateway.Changes
API
EVPNInstanceConfigresource underapi/cisco/nx/v1alpha1with theMultisiteIngressReplicationenum field (Disabled/Enabled/EnabledOptimized, defaultDisabled), registered as anEVPNInstancedependency.Provider (Cisco NX-OS)
EnsureEVPNInstancereadsmultisiteIngressReplicationfrom the referencedEVPNInstanceConfigand maps it to the VNI's device enum.nve.gofor the three modes.Generated / scaffolding
kustomization entries.
Samples
EVPNInstanceConfigsample plus Tiltfile wiring; the EVI sample now references it viaproviderConfigRef(commented out by default).Generated artifacts
config/crd/bases), Helm chart CRD copy, and API referencedocs to reflect the new enum field and its
Disableddefault.Notes
Disabled, so existingEVPNInstanceresources are unaffected.Testing
disable,enable,enableOptimized).evpninstance.txtar) updated: a default EVPNInstance now emits"multisiteIngRepl": "disable".make manifests generate helm fmt lint testandmake test-gnmi PROVIDER=cisco-nxos-gnmiall pass.Simulated device
Tested against a simulated Cisco N9K-C9300v in Clabernets. Results of reading the path using
gnmic -a 127.0.0.1 --port 9339 -u *** -p *** --skip-verify get -e json --values-only --path 'System/eps-items/epId-items/Ep-list[epId=1]/nws-items/vni-items/Nw-list[vni=100010]/multisiteIngRepl'spec.multisiteIngressReplication"Disabled"["disabled"]Enabled[]- causes controller errorEnabledOptimized["enableOptimized"]Setting
multisiteIngRepl: Enabledproduces the following error. This is expected, becauseevpn multisite border-gatewayis not yet supported in network-operator. This PR is a pre-requisite for supportingevpn multisite border-gateway.YANG
Reference https://github.com/YangModels/yang/blob/main/vendor/cisco/nx/10.6-3/Cisco-NX-OS-device.yang
Allowed values of
multisiteIngRepl: