Skip to content

Support xcode27 #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DGeoWils wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Support xcode27 #406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/ios/utils/simulator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Exception } from '../../errors';
import { log } from '../../utils/log';
import { onBeforeExit } from '../../utils/process';

import { getXCodePath } from './xcode';
import { getXCodePath, getXcodeVersionInfo } from './xcode';

const debug = Debug('native-run:ios:utils:simulator');

Expand Down Expand Up @@ -84,12 +84,13 @@ export async function runOnSimulator(udid: string, appPath: string, bundleId: st
}

const xCodePath = await getXCodePath();
const [xcodeVersion] = getXcodeVersionInfo();
const xcodeMajorVersion = Number(xcodeVersion.split('.')[0]);
const simulatorAppPath =
xcodeMajorVersion >= 27 ? `${xCodePath}/../Applications/DeviceHub.app` : `${xCodePath}/Applications/Simulator.app`;

debug(`Running simulator ${udid}`);
const openResult = spawnSync(
'open',
[`${xCodePath}/Applications/Simulator.app`, '--args', '-CurrentDeviceUDID', udid],
{ encoding: 'utf8' },
);
const openResult = spawnSync('open', [simulatorAppPath, '--args', '-CurrentDeviceUDID', udid], { encoding: 'utf8' });
if (openResult.status) {
throw new Exception(`There was an error opening simulator: ${openResult.stderr}`);
}
Expand Down