Repository navigation
Fix the joint position move (homing) - #14
Merged
Merged
Conversation
…at the target
- Start the motion from q_d instead of q. Starting from the measured position makes the first
command jump by q - q_d (audible jerk at the start, or a velocity/acceleration discontinuity
abort when the gap is larger, e.g. after the arm sagged in Idle).
- Skip the move if the arm is already within tolerance. A motion that finishes in its first
cycle is rejected by libfranka ("Motion finished commanded, but the robot is still moving").
- Stop retrying after a successful move. The loop ran 5 times even on success, each extra run
started at the target and failed as above.
- Return false when all retries fail instead of reporting the target as reached.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ngres
force-pushed
the
fix/homing-move
branch
from
November 17, 2026 18:29
860cff0 to
303a000
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use
robot_state.q_dinstead ofrobot_state.qto prevent jumps in the desired configuration