[benchmarker] Refactor congested_area.jsonnet into reusable components - #1738
Open
BenjaminPelletier wants to merge 1 commit into
Open
BenjaminPelletier wants to merge 1 commit into
BenjaminPelletier wants to merge 1 commit into
Conversation
BenjaminPelletier
marked this pull request as ready for review
September 28, 2026 21:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for creating two more benchmarker scenarios similar to congested_area.jsonnet (#1724), it would be advantageous to factor our reusable elements of congested_area.jsonnet so we don't have very large content sections manually repeated between configurations. This PR attempts to do that, as well as aligning on S2 cell characteristics. That is, congested_area is intended to make everything happen within a single S2 cell. These changes also leverage recent S2 functions to make this the case, and present areas of interest in terms of the inscribed LatLngRect for the S2 cell selected.
A slightly-older version of this PR yielded the graph below with the settings below.