[netrid/display_data_evaluator] Fix 'premature check' assuming perfect clock sync - #1737
Conversation
BenjaminPelletier
left a comment
There was a problem hiding this comment.
The only thing where I still doubt a bit is about the tolerance to use: this currently imports the F3548 constant
TimeSyncMaxDifferentialSecondsbecause there is no such equivalent in F3411. I'm not sure whether it would be better to just define a constant in the file.
I think the choice is well-documented here; I don't think an unlinked constant in this file would be any better. We may want to make this choice more universally for our treatment of F3411 at some point in which case it would be better to have all F3411 instances of something like this link to that single point where we can document the rationale once, but I think the current PR is superior for a one-off fix like this and appropriate indefinitely until we have more instances.
This fixes the netrid check for premature flights where it is assumed the clocks are perfectly in sync. This is very similar to #1476.
The only thing where I still doubt a bit is about the tolerance to use: this currently imports the F3548 constant
TimeSyncMaxDifferentialSecondsbecause there is no such equivalent in F3411. I'm not sure whether it would be better to just define a constant in the file.