Skip to content

[netrid/display_data_evaluator] Fix 'premature check' assuming perfect clock sync - #1737

Merged
BenjaminPelletier merged 1 commit into
mainfrom
netridtimeskew
Sep 28, 2026
Merged

BenjaminPelletier merged 1 commit into
mainfrom
netridtimeskew

Conversation

@mickmis

@mickmis mickmis commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

This fixes the netrid check for premature flights where it is assumed the clocks are perfectly in sync. This is very similar to #1476.
The only thing where I still doubt a bit is about the tolerance to use: this currently imports the F3548 constant TimeSyncMaxDifferentialSeconds because there is no such equivalent in F3411. I'm not sure whether it would be better to just define a constant in the file.

@BenjaminPelletier BenjaminPelletier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing where I still doubt a bit is about the tolerance to use: this currently imports the F3548 constant TimeSyncMaxDifferentialSeconds because there is no such equivalent in F3411. I'm not sure whether it would be better to just define a constant in the file.

I think the choice is well-documented here; I don't think an unlinked constant in this file would be any better. We may want to make this choice more universally for our treatment of F3411 at some point in which case it would be better to have all F3411 instances of something like this link to that single point where we can document the rationale once, but I think the current PR is superior for a one-off fix like this and appropriate indefinitely until we have more instances.

@BenjaminPelletier
BenjaminPelletier merged commit e1e3ad2 into main Sep 28, 2026
27 checks passed
@BenjaminPelletier
BenjaminPelletier deleted the netridtimeskew branch September 28, 2026 19:01
github-actions Bot added a commit to brandoncorrea/monitoring that referenced this pull request Sep 28, 2026
github-actions Bot added a commit to innovatm/interuss-monitoring that referenced this pull request Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants