disproportionate limb lenghts

I've noticed that disproportionate limb sizes appear sometimes when a new skeleton is instantiated. Looks like this could be caused by an improper limb length calculation maybe when there is not enough data to calculate or there is an issue on the calculation.
I've seen this issue appear in many different segments of the rigs (head, arms, legs...) so it doesn't seem like a limb specific issue.
image attached for reference

[johnhe4]

Are you able to share a paired-down dataset to reproduce this?

Sure @johnhe4 ! here is a short sequence of frames from the long armed subject above.
245_skeleton_245.txt

@johnhe4 , I verified and the issue is in the input data. I've modified the limb length calculation to use inter quartile range to remove outlier limb lengths from the average length calculation and it addresses the issue above well. Check limb_length_calc branch
What I've noticed is that if the skeleton enters the scene later in the sequence (i.e frame 25 instead of frame 0) in those cases the bad limb length still persists. Looks as if limb length calculation only gets applied for skeletons that start at first frame of the scene. If a skeletons enters the scene at a later frame in time, it seems to be using the instantaneous limb length at that frame, rather than the average across MIN_NUM_FRAMES of limb lengths without outlier.
Can you show me in the code, when a new rig is instantiated later in the scene how are the limb sizes calculated in those cases?

[johnhe4]

The relevant code begins in

riggingtools/kp2rig/src/AnimatedRig.cpp

Line 25 in bb346bd

DetermineBoneLengths( it );

It seems that it only depends on data for that character, regardless of what frame it is. Also, filling in missing frames happens afterwards so it should still work the same if there is one frame, then no frames for a while, then more frames for a character. I'm not sure why this is happening, but debugging in the code above will help. You can add debug checks for the character ID and frame number of interest (contained in the Pose object).