Repository navigation
3.x: Fix phpstan up to level 10 - #82
Merged
Merged
Conversation
acoulton
force-pushed
the
3.x-phpstan-l10
branch
from
October 27, 2026 13:44
cc5d729 to
7079fde
Compare
acoulton
force-pushed
the
3.x-phpstan-l10
branch
from
October 27, 2026 14:48
7079fde to
c90386e
Compare
The CSVWriter isn't currently final, so theoretically a child could modify the BOM constant to a non-string.
Ensure that the returned data structure has the expected format and the data is valid.
AbstractArrayRepository should not make so many assumptions about the incoming data.
Only count the lock as having been successful if we get an explicit `1` or `'1'` result. Previously we assumed it would always be one of these, but theoretically in an error condition we could get a value that can't properly cast to int which would have caused an error.
AssociativeArrayUtils::deepMerge will in practice return: * array<string, mixed> if all inputs were array<string, mixed> * array<mixed> if *any* input had numeric keys There is no easy way to report that to PHPStan (conditional return types don't cater for variadics) so we need to just tag the resultant variable.
There were a couple of phpstan errors coming up related to the class having potentially conflicting types in a child. In practice this never needs to be extended so we can safely just finalise it which solves all those issues.
acoulton
force-pushed
the
3.x-phpstan-l10
branch
from
October 27, 2026 14:59
c90386e to
9b36fc7
Compare
craig410
approved these changes
Oct 27, 2026
Member
Author
|
@craig410 I think that's all of these PRs now green and good to go if you're happy with them? I haven't done much CHANGELOG yet but can do that separately when we're ready to release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.