Repository navigation
feat: Upgrade to php 8.5, php-utils 3.x, and guzzlehttp/psr7 v2 or v3 - #6
Merged
Merged
Conversation
Optionally support either 2.x or 3.x. Note that one of the tests was coupled to Guzzle's default user-agent header, which we don't control. This now uses a hardcoded string in the test instead.
For stricter typing and new PHP compatibility.
acoulton
force-pushed
the
1.x-bump-deps
branch
from
November 4, 2026 09:12
5c4a02d to
00aecc6
Compare
If the response has begun to be sent before the exception (for
example, when checking for multiple response header values) then
the `HTTP/{proto} {status} {reason}` header might already have been
queued. Calling http_response_code after this has no effect, and causes
a warning on >= PHP 8.5.
Since we are already setting a Content-Type header in this handler, the
simplest solution is to set the response_code in that same call, which
will update the HTTP header string that's already been set.
Note that this change alters the line numbers in the main microframework
file, which breaks the (probably too brittle) test for the log output as
the stack trace line numbers have changed.
acoulton
force-pushed
the
1.x-bump-deps
branch
from
November 4, 2026 09:34
f6ac8bc to
e3d97c5
Compare
Previously this was not tested, because the base image we're using for tests does not include locales other than the default `C` (POSIX) locales, and therefore `setlocale` would not apply any custom locale.
Member
Author
|
@craig410 I've targeted this to a new 2.x series, as there are some BC breaks in method signatures in the later PRs and I think we're as well to bump the whole library at this point? |
craig410
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the base PHP and php-utils version requirements, and add support for newer Guzzle.
I've made the guzzle dependency support either v2 or v3 of guzzlehttp/psr7 to avoid dependency conflicts for end-user projects which may not yet be able to update to guzzlehttp/guzzle v8 if they have their own dependencies that need v7.