Repository navigation
feat!: BREAKING - provide the request to the handler factory - #13
Merged
Merged
Conversation
craig410
approved these changes
Nov 4, 2026
End-users can now implement simple routing to different RequestHandler classes, because the factory function now has access to the request as well as the logger. Rather than adding this as a second argument, I've refactored the callables to receive a new HandlerFactoryArgs DTO, which would make it easier for us to provide additional dependencies / variables / context to the handler factory in future without a BC break.
To account for variation between guzzlehttp/psr7 v2 and v3.
acoulton
force-pushed
the
feat-request-to-handler-factory
branch
from
November 4, 2026 16:27
c1d9a6e to
0ed62f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End-users can now implement simple routing to different RequestHandler
classes, because the factory function now has access to the request as
well as the logger.
Rather than adding this as a second argument, I've refactored the
callables to receive a new HandlerFactoryArgs DTO, which would make it
easier for us to provide additional dependencies / variables / context
to the handler factory in future without a BC break.
Stack created with GitHub Stacks CLI • Give Feedback 💬