Repository navigation
027: Finish expanded Oxide routing for Underlay coverage-tool installation guidance - #60
Merged
Merged
Conversation
inflatable-tester
approved these changes
Oct 23, 2026
inflatable-tester
left a comment
There was a problem hiding this comment.
Independent review of PR60 (head 9dd904d) against the Queue brief v1.
SCOPE / DIFF (read in full): Exactly the brief's expected diff, nothing more:
- README.md Coverage section:
cargo install cargo-tarpaulin->oxide install cargo-tarpaulin(args identical). - rust/scripts/check-coverage.sh missing-tool hint: same one-word switch, same args.
- docs/knowledge/contracts/022-testing-posture-and-shared-harnesses.md: new short
### Coverage toolingsubsection owning the clarification (install viaoxide install cargo-tarpaulin; execution stayscargo tarpaulin --workspace --out Xmlas an unqualified instrumentation/profile/platform exception). No AGENTS pointer was added; none needed for a hint-only change. - Diff vs base 1d0d5ec touches only these 3 files; merged 026/PR59 target-ignore correction and PR58 oxide build/check/clippy/test/fmt/fetch selectors plus AGENTS block are preserved byte-for-byte in the diff-check.
REVIEWER PROOFS (run personally, once):
bash -n rust/scripts/check-coverage.sh-> OK (raw bash -n is the brief-authorized syntax check; no Effigy selector covers syntax-only validation).effigy docs check links README.md docs/knowledge/contracts/022-testing-posture-and-shared-harnesses.md-> link check passed.- Exercised changed behaviour in an isolated mktemp fixture (private PATH without cargo-tarpaulin, no writes outside the fixture): script prints
cargo-tarpaulin not found. Install with:/oxide install cargo-tarpaulinand exits 1. New hint verified live. - Diff-check vs 1d0d5ec confirms exact 3-file scope; no 026-ignore-proof repetition (brief forbids it; inputs unchanged).
EXCEPTIONS VERIFIED RETAINED (all unchanged):
- Script still gates on
command -v cargo-tarpaulin, executescargo tarpaulin --workspace --out Xml, keeps parsing/threshold/exit behavior; nooxide tarpaulin/oxide execsubstitution. rust:check:cargo,rust:clippy:cargo,rust:test:cargoselectors intact in effigy.toml.- All six
.github/workflows/rust.ymlCargo invocations (fmt --check, clippy, build, test x3) untouched; no workflow changes. ts/scripts/check-release-version-sync.tsCargo-named variables untouched (manifest data, not invocations).- No private-target one-use routes manufactured; none added.
BROADER ROUTES OBSERVED (reported per brief, not expanded; NOT blockers, no whole-doc sweep performed):
- docs/guides/130-testing.md:699 still shows
cargo install cargo-tarpaulin(consumer-guide example). Left as-is per exact-diff acceptance; candidate for a docs follow-up if the adoption owner wants guides covered. - docs/guides/010-prerequisites.md (x2) and templates/scripts/setup.sh:167 reference
cargo install sqlx-cli-- a different tool outside this Tarpaulin-only task; untouched. - effigy.toml v0.15
[scan.attention_markers]retirement notice prints on every invocation; pre-existing, unrelated.
No compile/test/coverage/build/install/network performed, per the brief's explicit prohibition. Working tree left clean at the reviewed head; no tracked files edited, no commits, no branch switch.
Verdict: ready_to_merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oxide install cargo-tarpaulin.cargo tarpaulin --workspace --out Xml.Validation
bash -n rust/scripts/check-coverage.sheffigy qa:docs(passed; emitted the existing retired-config warning)git diff --check