Skip to content

027: Finish expanded Oxide routing for Underlay coverage-tool installation guidance - #60

Merged
betterthanclay merged 1 commit into
mainfrom
ns-54ac1998-6e1b-46c7-b73c-795dde114a63
Oct 23, 2026
Merged

betterthanclay merged 1 commit into
mainfrom
ns-54ac1998-6e1b-46c7-b73c-795dde114a63

Conversation

@betterthanclay

Copy link
Copy Markdown
Contributor

Summary

  • Route both Tarpaulin install hints through oxide install cargo-tarpaulin.
  • Record the retained Cargo execution exception in contract 022; the script still checks and runs cargo tarpaulin --workspace --out Xml.

Validation

  • bash -n rust/scripts/check-coverage.sh
  • effigy qa:docs (passed; emitted the existing retired-config warning)
  • git diff --check

@inflatable-tester inflatable-tester left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review of PR60 (head 9dd904d) against the Queue brief v1.

SCOPE / DIFF (read in full): Exactly the brief's expected diff, nothing more:

  • README.md Coverage section: cargo install cargo-tarpaulin -> oxide install cargo-tarpaulin (args identical).
  • rust/scripts/check-coverage.sh missing-tool hint: same one-word switch, same args.
  • docs/knowledge/contracts/022-testing-posture-and-shared-harnesses.md: new short ### Coverage tooling subsection owning the clarification (install via oxide install cargo-tarpaulin; execution stays cargo tarpaulin --workspace --out Xml as an unqualified instrumentation/profile/platform exception). No AGENTS pointer was added; none needed for a hint-only change.
  • Diff vs base 1d0d5ec touches only these 3 files; merged 026/PR59 target-ignore correction and PR58 oxide build/check/clippy/test/fmt/fetch selectors plus AGENTS block are preserved byte-for-byte in the diff-check.

REVIEWER PROOFS (run personally, once):

  1. bash -n rust/scripts/check-coverage.sh -> OK (raw bash -n is the brief-authorized syntax check; no Effigy selector covers syntax-only validation).
  2. effigy docs check links README.md docs/knowledge/contracts/022-testing-posture-and-shared-harnesses.md -> link check passed.
  3. Exercised changed behaviour in an isolated mktemp fixture (private PATH without cargo-tarpaulin, no writes outside the fixture): script prints cargo-tarpaulin not found. Install with: / oxide install cargo-tarpaulin and exits 1. New hint verified live.
  4. Diff-check vs 1d0d5ec confirms exact 3-file scope; no 026-ignore-proof repetition (brief forbids it; inputs unchanged).

EXCEPTIONS VERIFIED RETAINED (all unchanged):

  • Script still gates on command -v cargo-tarpaulin, executes cargo tarpaulin --workspace --out Xml, keeps parsing/threshold/exit behavior; no oxide tarpaulin/oxide exec substitution.
  • rust:check:cargo, rust:clippy:cargo, rust:test:cargo selectors intact in effigy.toml.
  • All six .github/workflows/rust.yml Cargo invocations (fmt --check, clippy, build, test x3) untouched; no workflow changes.
  • ts/scripts/check-release-version-sync.ts Cargo-named variables untouched (manifest data, not invocations).
  • No private-target one-use routes manufactured; none added.

BROADER ROUTES OBSERVED (reported per brief, not expanded; NOT blockers, no whole-doc sweep performed):

  • docs/guides/130-testing.md:699 still shows cargo install cargo-tarpaulin (consumer-guide example). Left as-is per exact-diff acceptance; candidate for a docs follow-up if the adoption owner wants guides covered.
  • docs/guides/010-prerequisites.md (x2) and templates/scripts/setup.sh:167 reference cargo install sqlx-cli -- a different tool outside this Tarpaulin-only task; untouched.
  • effigy.toml v0.15 [scan.attention_markers] retirement notice prints on every invocation; pre-existing, unrelated.

No compile/test/coverage/build/install/network performed, per the brief's explicit prohibition. Working tree left clean at the reviewed head; no tracked files edited, no commits, no branch switch.

Verdict: ready_to_merge.

@betterthanclay
betterthanclay merged commit 0bf8178 into main Oct 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants