Skip to content

Add TypeScript format and check selectors - #57

Merged
betterthanclay merged 1 commit into
mainfrom
tooling/typescript-format-selectors
Oct 20, 2026
Merged

betterthanclay merged 1 commit into
mainfrom
tooling/typescript-format-selectors

Conversation

@betterthanclay

Copy link
Copy Markdown
Contributor

Underlay had no Effigy selector for TypeScript formatting. Add fmt:ts and read-only fmt:ts:check, using local Prettier 3.9.9 with committed tabs/double-quotes configuration and explicit file arguments. This development dependency and its lock entry are the only dependency changes.

Document the commands in AGENTS, README and the testing contract. Existing source files, Svelte formatting, CI workflows and health/validate/QA composition are unchanged.

Validation:

  • Actual selectors on one temporary unformatted TypeScript file: check exits 1, format exits 0, check exits 0; fixture removed.
  • Existing ts/src/client/pagination.ts formatting check passes.
  • effigy qa:docs and git diff --check pass.
  • No Rust build/test or full QA run; no Rust or runtime source changed.

Addresses papercut a5d52b9e-deac-4c2f-a2fe-b66c7a1defeb under Tom's “Go for it” authorization on 2026-10-20.

@inflatable-tester inflatable-tester left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

None. I found no blocking or non-blocking issues in the reviewed change.

Review evidence

Reviewed PR #57 at e17504f989977318f12b93aa6608aea8e7ad2090 against base d0c1576a55fd72df7c259765705698f41dfaa961. The exact seven-file diff stays within the approved formatter, lockfile, and documentation scope. The package and lockfile pin Prettier 3.9.9; bun install --frozen-lockfile succeeded and the local binary reported 3.9.9.

The isolated Effigy selector smoke covered a filename with spaces, root configuration discovery, and selected-file behavior: the initial fmt:ts:check returned 1 without modifying the file, fmt:ts returned 0 and applied the committed double-quote and semicolon settings, and the final check returned 0. A TypeScript parse error returned nonzero, an unselected fixture remained untouched, and a filename containing literal command-substitution syntax passed as a single file argument.

effigy qa:docs and git diff --check passed. The lockfile diff contains only the root Prettier dependency and the matching 3.9.9 package resolution. The README, AGENTS guidance, and owning testing contract describe the selector scope consistently. The manifest adds only the two standalone selectors; health, validate, QA composition, Svelte formatting, runtime source, and CI files are unchanged.

The PR description reports the author's temporary-file smoke and existing pagination check. GitHub reports a successful Rust workflow for the reviewed head; PR comments and review threads are empty. The worktree remains clean at the expected head.

@betterthanclay
betterthanclay merged commit 04f3085 into main Oct 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants