Repository navigation
Build jsonwebtoken with aws-lc-rs to drop rsa (RUSTSEC-2023-0071) - #56
Merged
Merged
Conversation
Underlay only signs Ed25519 JWTs; the rust_crypto backend pulled in rsa (RUSTSEC-2023-0071, no fix) and unused curve crates. aws-lc-rs is already in the graph via rustls. Drop the deny ignore and allow-list the nightfire git source so cargo deny passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
underlay-auth-jwtswitchesjsonwebtokenfromrust_cryptotoaws_lc_rs. Underlay only uses Ed25519. The RustCrypto backend compiled inrsa(Marvin, RUSTSEC-2023-0071, no fixed release) plus unused curve crates.aws-lc-rswas already present through rustls, in Underlay, Reference and compli-me.rsa,pkcs1,num-bigint-dig,p384,ed25519-dalek,curve25519-dalek, …), +1 (untrusted).deny.toml: drops the now-unneededRUSTSEC-2023-0071ignore and allow-lists thenightfiregit source, which already failedcargo deny check sourcesonmain.[Unreleased]carries the contract-023 upgrade note.Validation
effigy rust:test: 961 passed, 0 failed.effigy rust:clippy,effigy rust:check,changelog validatepass.cargo deny check: advisories, bans, licenses and sources ok. Token compatibility: Ed25519 signing is deterministic and standard, so existing tokens keep verifying.🤖 Generated with Claude Code