Repository navigation
Hull: evaulate_at_zero function - #148
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #148 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 21 21
Lines 2265 2298 +33
=======================================
+ Hits 2258 2291 +33
Misses 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dnguyen227
marked this pull request as ready for review
October 8, 2026 16:55
Contributor
Author
|
@pulsipher ready for review. This replaces the JuMP.value(vref) PR on InfiniteOpt. |
pulsipher
reviewed
Oct 8, 2026
pulsipher
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nonlinear hull reformulation computed the perspective constant f(0) with
JuMP.value(v -> 0.0, con.func). This doesnt work forGeneralVariableRefevaluate_at_zerothat goes through numbers, variables, affine, quadratic, and nonlinear expressions. This allows for dispatch in InfGDP.dispatch_variable_refshould ensure that we're only evaluating things we're confident about. Can build out other types as they come up, but this solves the issue of variables insideGeneralVariableReferroring out when they shouldnt.