Repository navigation
Conversation
rigazilla
force-pushed
the
feat/test-count-badge
branch
from
October 9, 2026 15:18
1d2f5f4 to
d71b5a3
Compare
The test counts were hand-typed in ~6 places across README.md and docs/STATUS.md and had already drifted. A CI-published shields.io badge (count_tests.sh + an orphan 'badges' branch force-pushed from CI) was prototyped to fix this, but is overkill for a solo, intermittently-worked repo. Instead, just remove the duplication: docs/STATUS.md (authoritative current-state doc) carries the totals once; README and the directory tree describe what is covered and defer to STATUS.md. Removes the CI badge step, scripts/count_tests.sh, and the README badges. DECISIONS.md records the badge as considered-and-rejected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rigazilla
force-pushed
the
feat/test-count-badge
branch
from
October 12, 2026 13:53
d71b5a3 to
39de3df
Compare
rigazilla
changed the title
rigazilla
added a commit
that referenced
this pull request
Oct 19, 2026
… convention
STATUS.md trimmed to current-state-only (per AGENTS.md/WORKFLOW.md):
- ⏭ Next steps rebuilt as a clean 1–3 (Step 12 / benchmark / cleanup) + a
one-line "recently shipped" pointer; dropped the completed-work narrative pile
and fixed the broken numbering.
- Backlog reduced to open [ ] items only; completed [x] blocks removed (they live
in "Working and shipped" + dated DECISIONS entries).
- Removed the ~88-line Step-10 implementation plan (shipped work); its schema-bug
gotcha was preserved in DECISIONS.md first.
- Refreshed stale date stamps (2026-09-16 / 2026-10-09 → 2026-10-19) and stale
phrasings ("all four operations"; ops table).
Adopt PR #14's convention (imported here; PR #14 closed unmerged as stale):
- Test counts live once, in STATUS.md "Test status" (250 unit / 96 integration /
20 suites, read via --gtest_list_tests). README drops all hard counts and points
to STATUS for the breakdown.
- Imported PR #14's "stop repeating test counts" DECISIONS entry (dated 2026-10-09,
placed chronologically) with a provenance note.
DECISIONS.md: fixed the one non-date heading (multiplexing landing → 2026-07-02,
per commit 5b35248); preserved the replace_if_unmodified nibble-flip schema gotcha.
README.md: Current Progress / milestone footer now include multi-server seed list
(#12); test-count strings removed per the convention above.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
|
Closing unmerged — superseded. This PR had gone stale/conflicting against Its decision and convention have been re-applied on the
Nothing here is lost — see PR #16. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13.
Why
Test counts were hand-maintained in ~6 places across
README.mdanddocs/STATUS.mdwith nothing verifying them, so they had drifted (a README spot still read "223 unit tests").What changed — and a change of direction
This PR originally published the counts as a CI-generated shields.io badge (a
count_tests.shhelper plus an orphanbadgesbranch force-pushed from CI). That approach was prototyped and then rejected as overkill for a solo, intermittently-worked repo: it added a CI step withcontents: write, an orphan branch, a helper script, and a badge that 404s until the first post-merge run and lags CDN caching — a lot of moving parts to avoid typing a number.Instead, the PR now simply removes the duplication:
docs/STATUS.md(the authoritative current-state doc) carries the totals once — 250 unit / 92 integration / 19 suites.README.mddrops all hard counts (the### Unit Tests/### Integration Testsheadings, the "Test Results" block, the directory-tree comments) and defers to STATUS.md.docs/DECISIONS.mdrecords the badge as considered-and-rejected, and notes--gtest_list_testson the built binaries as the quick way to refresh the single count when it drifts.No CI, script, or workflow changes remain —
.github/workflows/build.ymlis back to itsmainstate andscripts/count_tests.shis gone.Verification
unit_tests+ the ctestintegration-labelled suites via--gtest_list_tests):250 92 19.🤖 Generated with Claude Code