Skip to content

Show quest rewards before completion (1.20.1) - #175

Closed
Cride24 wants to merge 6 commits into
infernalstudios:1.20.1from
Cride24:codex/reward-overview-only-1.20.1
Closed

Cride24 wants to merge 6 commits into
infernalstudios:1.20.1from
Cride24:codex/reward-overview-only-1.20.1

Conversation

@Cride24

@Cride24 Cride24 commented Sep 27, 2026 •

Copy link
Copy Markdown

This brings the reviewed reward-preview implementation from #173 to Minecraft 1.20.1 (Forge and Fabric). Reward previews are off by default through showRewardPreviews in the client config; quests can inherit that setting or override it with show_rewards_before_completion (Show/Hide in the editor). Completed quests retain the original rewards-only panel, and previews cannot be selected or collected early.

The review response, design details, and screenshots are in the #173 discussion.

Closes #167.

Validation

  • Focused headless checks and Forge/Fabric 1.20.1 builds passed for this branch.
  • The contributor tested the updated build in both Forge and Fabric 1.20.1. The client setting and Default/Show/Hide quest overrides behaved as expected; the reward display, editor cycle, and tested collection/choice cases worked, except for the Fabric loot-table case below.
  • On Fabric 1.20.1, claiming the dungeon loot-table reward failed. The log reports an IllegalArgumentException in LootTableReward.applyReward for parameters not allowed by LootContextParamSets.EMPTY. That method is unchanged from the upstream 1.20.1 branch; the same test worked on Forge 1.20.1 and NeoForge 1.21.1. This separate issue is not addressed here.
  • Multiplayer has not been tested.

This contribution was prepared with AI assistance; the in-game tests were performed by the contributor.

@Cride24

Cride24 commented Sep 29, 2026

Copy link
Copy Markdown
Author

I updated this branch to match the reviewed 1.21.1 implementation. Please see my response on #173 for the change-by-change explanation and screenshots.

The updated 1.20.1 build was tested in game on Forge and Fabric. The reward-preview settings and tested reward cases passed, apart from a Fabric loot-table claim failure noted in the PR description; I will report that separately.

@SwanX1 SwanX1 closed this Sep 29, 2026
@Cride24
Cride24 deleted the codex/reward-overview-only-1.20.1 branch September 30, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visible Quest Rewards

2 participants