Repository navigation
Conversation
Author
|
I updated this branch to match the reviewed 1.21.1 implementation. Please see my response on #173 for the change-by-change explanation and screenshots. The updated 1.20.1 build was tested in game on Forge and Fabric. The reward-preview settings and tested reward cases passed, apart from a Fabric loot-table claim failure noted in the PR description; I will report that separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the reviewed reward-preview implementation from #173 to Minecraft 1.20.1 (Forge and Fabric). Reward previews are off by default through
showRewardPreviewsin the client config; quests can inherit that setting or override it withshow_rewards_before_completion(Show/Hide in the editor). Completed quests retain the original rewards-only panel, and previews cannot be selected or collected early.The review response, design details, and screenshots are in the #173 discussion.
Closes #167.
Validation
IllegalArgumentExceptioninLootTableReward.applyRewardfor parameters not allowed byLootContextParamSets.EMPTY. That method is unchanged from the upstream 1.20.1 branch; the same test worked on Forge 1.20.1 and NeoForge 1.21.1. This separate issue is not addressed here.This contribution was prepared with AI assistance; the in-game tests were performed by the contributor.