Skip to content

Add optional quest details and editor support (1.21.1) - #174

Closed
Cride24 wants to merge 4 commits into
infernalstudios:1.21.1from
Cride24:codex/quest-details-only-1.21.1
Closed

Cride24 wants to merge 4 commits into
infernalstudios:1.21.1from
Cride24:codex/quest-details-only-1.21.1

Conversation

@Cride24

@Cride24 Cride24 commented Sep 27, 2026 •

Copy link
Copy Markdown

The Details button currently opens a second page showing the quest description again. This change adds an optional details field for separate, additional information.

Changes

  • Keep description on the overview and show details on a separate page with only Back, returning to the overview.
  • Hide the Details button when the optional text is absent or empty; never repeat the description as a fallback. Preserve existing visibility/open-by-default settings.
  • Support text components and translation keys, serialization and client synchronization.
  • Add Details directly below Description in the in-game editor; emptying it removes the optional field.
  • Use Questlog scrollbar textures for both fields, with independent wheel scrolling and scrollbar dragging. Keep parent-panel scrolling and mouse release working.
  • Document the field, /questlog edit_mode true, empty values and editor controls; include a quest example.

Existing per-quest panel sizes and prerequisite behavior are preserved.

Validation

  • 35 automated details checks and 18 headless editor-scrolling checks passed.
  • Manual checks covered different/absent/empty details, navigation, editor saving/clearing, and text-field scrolling. The contributor confirmed the final editor correction in game.
  • Gradle compilation/build checks passed for Minecraft 1.21.1 / NeoForge and Fabric.
  • The latest combined test build was manually validated by the contributor on NeoForge 1.21.1; matching functionality also passed on Forge and Fabric 1.20.1. Gameplay validation used the combined build, rather than each isolated PR branch.
  • Fabric 1.21.1 was build-checked but has not been tested in game.
  • Headless checks do not verify rendered UI; visual/gameplay results above are manual. Multiplayer has not been validated.

This contribution was prepared with AI assistance; the contributor performed the gameplay tests. Each new feature PR is based directly on its matching upstream Minecraft branch and can be accepted independently.

Matching Minecraft-version PR: #176.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant