ieee80211: populate and verify legacy PLCP header fields - #1210
Draft
mgonzalezlopezudc wants to merge 1 commit into
Draft
mgonzalezlopezudc wants to merge 1 commit into
mgonzalezlopezudc wants to merge 1 commit into
Conversation
DSSS transmission previously left SIGNAL zero and serialized PSDU octets as airtime. Preserve the byte-length model contract and carry the independent wire duration, including the 11 Mbps length-extension bit. Populate FHSS PLW and PSF and serialize their specified bit order. Computed DSSS, HR-DSSS and FHSS CRC now checks the protected wire fields. Tests exercise real radio encapsulation and reception, an independent DSSS CRC vector, extension boundaries, protected-field corruption and declared checksum modes. IR computed mode fails explicitly instead of claiming unconditional success; full IR CRC support remains unresolved. Change: src.ieee80211.phy | behavior.change.fix | test migration | wifi-audit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DSSS PLCP SIGNAL/LENGTH used incorrect units and computed CRC was a stub. Preserve PSDU byte length separately, populate wire airtime/rate/extension fields, and compute/verify DSSS, HR-DSSS and FHSS CRC.
Scope
PHY header representation, serializers, radio encapsulation/decapsulation and test fillers.
Dependencies and merge order
No prerequisite within this audit series; this topic was built and tested independently on the pinned base.
Validation
Pinned test base:
7287f347aaca36e557c708d6930a6f5a450b2833.The isolated topic head passed an assertions-enabled debug build (
-O0 -Wall -g0; debug symbols omitted for storage) and the focused checks below. The larger integration source tree also passed debug and release compilation; no separate release build is claimed for this topic.Executed focused test commands, from the repository root after
source setenv -q:inet_run_unit_tests -m debug -f 'Ieee80211(LegacyPlcp|RadioWireIdentity|OnWireBitCompliance)_1\.test'Results: 3 unit cases passed.
Limits and review status
IR computed mode explicitly rejects unsupported CRC; full IR support remains unresolved. Declared modes are retained.
Draft pending final independent review and reconciliation with current upstream. Live PR overlap has not been reverified against the pinned test base.