ieee80211: use two-message Open System authentication - #1208
Draft
mgonzalezlopezudc wants to merge 2 commits into
Draft
mgonzalezlopezudc wants to merge 2 commits into
mgonzalezlopezudc wants to merge 2 commits into
Conversation
STA management frames built before association omitted Address3. Carry the procedure-selected BSSID in a typed request tag and honor it at MAC header construction, preserving the AP fallback and keeping receiver address distinct from BSSID. A real STA scan/authentication/association test checks management Address3 at the MAC boundary, including wildcard probes. Change: src.ieee80211.management | behavior.change.fix | test | wifi-audit
The AP defaulted to four dummy steps while serializing algorithm zero, and STA completion depended on a field absent from the wire. Preserve the algorithm number in the body, accept only Open System request 1/response 2, and reject invalid inputs before changing peer state. Keep isLast only as unused source compatibility metadata. numAuthSteps now defaults to 2 and rejects unsupported four-step configurations explicitly. Migrate repository handover configurations to 2. Wire round-trip, real association, invalid-input tests and all eleven affected MIPv6 module scenarios pass in debug mode. Change: src.ieee80211.authentication | behavior.change.fix | test migration | wifi-audit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The AP default performed four transactions while encoding Open System. Use algorithm 0 transactions 1/2, preserve raw algorithm values, and reject unsupported algorithms or unexpected transactions before state changes.
Scope
Management frame representation/serializer, AP/STA authentication and explicit four-step configurations; BSSID prerequisite first.
Standards references: IEEE 802.11-2024 §§9.4.1.1–9.4.1.2 and 12.3.3.2.
Dependencies and merge order
Depends on #1199 (management BSSID and Capability Information). Merge that PR first.
This branch currently carries the BSSID prerequisite, but not the capability changes. The prerequisite commit is already covered by the management PR. After it merges, rebase this branch onto updated
master, drop the equivalent BSSID prerequisite, resolve overlapping management/MAC changes, and rerun this PR’s focused tests. This PR is not ready to merge before that reconciliation.Validation
Pinned test base:
7287f347aaca36e557c708d6930a6f5a450b2833.The isolated topic head passed an assertions-enabled debug build (
-O0 -Wall -g0; debug symbols omitted for storage) and the focused checks below. The larger integration source tree also passed debug and release compilation; no separate release build is claimed for this topic.Executed focused test commands, from the repository root after
source setenv -q:Results: 1 unit, 13 module, 1 protocol cases passed.
Limits and review status
numAuthSteps=4 now fails explicitly. Shared Key authentication is not implemented.
Draft pending final independent review and reconciliation with current upstream. Live PR overlap has not been reverified against the pinned test base.