Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In HTTP mode,
handleMCPHTTPlogs every request body and every response at info, the default log level:Request body: ...contains the tool arguments the agent passes (e-mail addresses, keys, anything a tool takes as a parameter).Response: ...contains the tool output, i.e. whatever the shell command printed (kubectl/aws output, file contents, environment values).With
--logfilethese lines also go to the file. The stdio mode does not log them.This change moves those three lines to debug, so
--log-level debugstill shows them for troubleshooting, while the default info level keeps only the connection line andmethod=... id=....Tested locally: built from main, ran
mcp --httpwith a one-tool config, sentinitializeandtools/callwith curl. Before: arguments and output in the log at info. After: only the connection and method/id lines at info;go test ./pkg/server/...passes.