Repository navigation
fix: interrupt retry waits when the request context ends - #543
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
Stop a pending retry when the request is canceled or its deadline ends. Keep the response and return the context error to the caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Cancellation during a retry delay currently waits for the full interval. An expired request deadline also allows another retry.
Use the request context to interrupt the delay and return its error. Keep the last response body intact when the wait is interrupted.
The wait also respects a context replaced by a retry hook. Individual HTTP client timeouts still retry while the request context remains active.
The CI command,
go test ./... -coverprofile=coverage.txt, passes on Go 1.25.14 and 1.26.3 in Docker.All 354 tests and subtests pass. All 11 new cases pass 50 race repetitions. Ten fail on untouched master.
go build ./...,go vet ./..., and formatting pass.Full race tests expose existing races in
TestEnableDumpAll,TestEnableDump, andTestDumperAsync. Untouched master reproduces all three.