Repository navigation
ci: test vc_validation without status-list - #134
daniel-mader wants to merge 1 commit into
Conversation
`status_claim_without_status_list_feature` compiles only without the `status-list` feature. No CI step ran `vc_validation` that way: `--all-features` and the `vc,status-list` step both enable it, and `cargo hack clippy --each-feature` compiles the test without running it. The Features job now also runs it with `vc,did-key,did-jwk`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PB1rHNJ3YpjogEUJQYccc2
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Add feature-disabled validation run .github/workflows/qa.yml |
The features job adds a vc_validation run with vc,did-key,did-jwk and without status-list. A comment describes the expected StatusPolicy::Strict outcome when a status claim reaches no check. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related PRs
- impierce/identity-kit#133: Moves status-claim validation to the
status-listfeature and changes the feature-disabled test configuration. - impierce/identity-kit#94: Adds JWT
status-claim validation and defines strict-policy behavior when no status check is available.
Merge Risk: 
6064a
-
The workflow adds targeted coverage for status validation without the status-list feature and is mergeable.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: adding CI coverage for vc_validationwithout thestatus-listfeature.Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 … Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
|
@coderabbitai review Generated by Claude Code |
✅ Action performed
|
Follows up CodeRabbit's review of #133.
tests/vc_validation.rshas a test that compiles only without thestatus-listfeature:status_claim_without_status_list_feature. It checks thatStatusPolicy::Strictrefuses a credential'sstatusclaim when no check can receive it. No CI step ran it:cargo test --all-featuresenablesstatus-list;vc,status-list,did-key,did-jwkstep enables it too;cargo hack clippy --each-featurecompiles the test withoutstatus-listbut doesn't run it.So a regression in the
not(feature = "status-list")branches ofsrc/vc/validation/mod.rswould pass CI. The gap predates #133, when the test was gated onsd-jwt.Change
The Features job now also runs:
cargo test --no-default-features --features vc,did-key,did-jwk --locked --test vc_validationChecks
status_claim_without_status_list_feature.qa.ymlparses as YAML.Generated by Claude Code
Summary by CodeRabbit
vc_validationwithout the status-list feature, including strict handling of status claims.