Repository navigation
feat: cross-engine case-insensitive data diff, column-level row-diff, and HTML report viewer - #128
Merged
Merged
Conversation
…match image, and sample 18
…1.25.13 and text to v0.39.0
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (27)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
15 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces cross-engine case-insensitive table discovery and row hashing, a new column-level row inspection engine (
row-diffcommand anddiff --row-diffflag), interactive HTML report viewer enhancements, and security vulnerability fixes for Go 1.25.13 andgolang.org/x/text.It specifically addresses real-world migration verification issues (such as PostgreSQL$\leftrightarrow$ Oracle pipelines) where default catalog case folding (lowercase
um_user_attributein PostgreSQL vs. UPPERCASEUM_USER_ATTRIBUTEin Oracle) previously resulted in false-negative "No differences found" results.Type of Change
Changes Made
1. Cross-Engine Case-Insensitive Discovery & Dialect Handling
schema.CanonicalIdentacross all database engines."customers"), Oracle uses UPPERCASE ("CUSTOMERS"), MySQL uses backticks (`customers`), and MSSQL uses brackets ([customers]).resolve.FetchConflictRowsCrossEnginewith independent source/target connection drivers.2. Column-Level Row Inspection Engine (
row-diff)deepdiffdb row-diffwith flags for--table,--key,--status(updated,added,removed,all),--limit, and--format(tableorjson).--row-diffflag todeepdiffdb diffto display side-by-side differing columns in terminal output.*) and saved to structuredrow_diff.jsonand human-readablerow_diff.txt.3. Interactive HTML Report Viewer Enhancements
#rowdiff,#data, and#conflictsdeep linking on page load.4. Documentation Site & Sample Project
website/docs/features/cross-engine-diff.mddetailing cross-engine migration verification challenges, pipeline mismatch screenshots, and terminal illustrations.website/docs/commands/row-diff.mdand updatedwebsite/docs/commands/diff.md.website/static/samples/report.htmlandwebsite/docs/features/html-reports.md.samples/18-cross-engine-row-diff/with Docker Compose for PostgreSQL 16um_user,um_user_attribute), configuration, Makefile, and pre-generated diff outputs.CHANGELOG.mdunder## [Unreleased].5. Security Vulnerability Fixes
go.modto Go1.25.13andci.ymlmatrix/steps to1.25.13, resolving 8 Go standard library CVEs.golang.org/x/texttov0.39.0(resolves GO-2026-5970)..github/workflows/security.ymlto usego-version-file: go.modinstead of hardcoded older Go versions.Testing
tests/resolve/rowdiff_test.go,tests/resolve/fetch_test.go,tests/html/generator_test.go)test-pg-1)test-ora-1)govulncheck ./...(0 vulnerabilities)Test Results
Checklist
Additional Notes
Tested against real cross-engine dataset (PostgreSQL$\leftrightarrow$ Oracle) with table name case mismatches (
customersvs.CUSTOMERS,um_uservs.UM_USER). Verified that single-row inspection via--tableand--keyexecutes targeted queries without full table scans.Summary by CodeRabbit
row-diffto inspect column-level differences in updated, added, and removed rows, with table, key, and status filters and text or JSON output.