Repair Scorecard CI and prevent security scan false positives - #122
Merged
Merged
Conversation
…tents: read Two defects, and fixing only the first would look like a cure while changing nothing. 1. `permissions: read-all` is a SCALAR, so the indented `actions: read` beneath it is a mapping entry under a scalar: invalid YAML. GitHub never parsed the file, the run emitted zero jobs, and the Scorecard check never appeared. The gate was ABSENT, not red. 2. The `analysis` job declares its own `permissions:` block naming only `security-events` and `id-token`. A job-level block REPLACES the workflow-level one rather than merging with it, so the reusable workflow was being called without `contents: read` and could not check out. Deleting the orphan key alone would yield a file that parses and still emits no check. Adds `contents: read` to the job block, matching aerie#76 (merged 2026-09-13), which carries exactly these three job permissions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178nN4Nm3neFRy5K9StZKnB
The job-level `permissions:` block REPLACES the workflow-level block, so the reusable workflow's own `actions: read` cannot elevate the caller's token. Without it the caller's effective `actions` permission is `none`, and Scorecard's Packaging check (Actions.ListWorkflowRunsByFileName) can error. Caught by CodeRabbit on palimpsest-license#151; verified against the whole family: 11 of 13 scorecard.yml callers omit it, including aerie which is already on main. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178nN4Nm3neFRy5K9StZKnB
Contributor
Author
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
hyperpolymath
enabled auto-merge (squash)
September 17, 2026 10:21
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the Scorecard workflow’s invalid permissions structure and grant its caller job the actions, contents, security-events, and id-token access it requires. Generate synthetic API-token fixtures to avoid secret-scanner false positives, and document inert unsafe-function scanner signatures as non-proof-debt. Validation was not run.
View coding task