Skip to content

fix(ci): repair unparseable permissions scalar (2 workflow file(s)) - #121

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/workflow-permissions-scalar-parse-error
Sep 15, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/workflow-permissions-scalar-parse-error

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

permissions: read-all followed by an indented actions: read is a YAML
parse error. The workflow never starts, so it emits no check run — a
required context silently never reports, and this repository currently looks
greener than a repaired one.

read-all already grants actions: read, so removing the stray line is a
semantic no-op. Each file was verified with a real YAML parser: it fails
yq before the change and parses after it. Every diff is exactly one deleted line.

Files changed: e2e.yml scorecard.yml

Measured estate-wide: 42 such files across 28 repositories on main, all
carrying the identical stray key. Zero overlap with the TokenPermissions sweep.

🤖 Generated with Claude Code

https://claude.ai/code/session_0178nN4Nm3neFRy5K9StZKnB

A scalar `permissions: read-all` followed by an indented `  actions: read`
is a YAML parse error, so the workflow never starts. It emits no check run at
all, which means a required context silently never reports and the repository
looks greener than a repaired one.

`read-all` already grants `actions: read`, so deleting the stray line is a
semantic no-op. Verified with a real parser: each file fails `yq` before the
change and parses after it.

Files: e2e.yml scorecard.yml

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0178nN4Nm3neFRy5K9StZKnB
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a9257f26-4e46-4d86-bfb8-560e28bd3bfd

📥 Commits

Reviewing files that changed from the base of the PR and between 8e8279c and a709194.

📒 Files selected for processing (1)
  • .github/workflows/e2e.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/e2e.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (22)
  • GitHub Check: rust-ci / Cargo check + clippy + fmt
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: scan / shell-secrets
  • GitHub Check: scan / gitleaks
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: Validate A2ML manifests
  • GitHub Check: Groove manifest check
  • GitHub Check: validate
  • GitHub Check: analyze (javascript-typescript, none)
⚠️ CI failures not shown inline (2)

GitHub Actions: Central Estate CI/CD Audit / 0_estate-audit.txt: fix(ci): repair unparseable permissions scalar (2 workflow file(s))

Conclusion: failure

View job details

##[group]GITHUB_TOKEN Permissions
 Contents: read
 Metadata: read
 Packages: read
 ##[endgroup]
 Secret source: Actions
 Cache mode: write
 Prepare workflow directory
 Prepare all required actions
 Getting action download info
 ##[error]The actions actions/checkout@v4 and hyperpolymath/cicd-suite/actions/required-files-check@main are not allowed in hyperpolymath/panll because all actions must be pinned to a full-length commit SHA.

GitHub Actions: Central Estate CI/CD Audit / estate-audit: fix(ci): repair unparseable permissions scalar (2 workflow file(s))

Conclusion: failure

View job details

##[group]GITHUB_TOKEN Permissions
 Contents: read
 Metadata: read
 Packages: read
 ##[endgroup]
 Secret source: Actions
 Cache mode: write
 Prepare workflow directory
 Prepare all required actions
 Getting action download info
 ##[error]The actions actions/checkout@v4 and hyperpolymath/cicd-suite/actions/required-files-check@main are not allowed in hyperpolymath/panll because all actions must be pinned to a full-length commit SHA.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated automated build and testing permissions to support more reliable workflow execution.
    • No changes to end-user functionality or product behaviour.

Walkthrough

The end-to-end workflow changes its workflow-level token permissions from actions: read to read-all.

Changes

Workflow permissions

Layer / File(s) Summary
Update workflow permissions
.github/workflows/e2e.yml
The workflow-level permission mapping changes from actions: read to read-all.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: metadatastician

Merge Risk: ⚪ Minimal · up to a7091

The workflow remains configured with read-only token access and has no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description directly explains the YAML parse error, the permission change, the affected workflow files, and the verification performed.
Title check ✅ Passed The title clearly identifies a CI fix for an unparseable permissions scalar and states that two workflow files are affected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow door
Read-only keys now reach each scope
The end-to-end path hops ahead
No write permission marks the way
Soft paws approve the change

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) September 14, 2026 22:19
scorecard.yml is already repaired on branch fix/repair-startup-dead-scorecard-yml
(PR #120), which re-indents `actions: read` INTO the analysis job's own
permissions block. That is the correct cure: job-level permissions REPLACE the
top-level map, so the analysis job never inherited `read-all` and Scorecard was
running without `actions: read`. Deleting the stray line made the file parse but
left the job functionally short.

Restoring this file from main so PR #120 owns it uncontested.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0178nN4Nm3neFRy5K9StZKnB
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@hyperpolymath
hyperpolymath merged commit 9786c5a into main Sep 15, 2026
28 of 37 checks passed
@hyperpolymath
hyperpolymath deleted the fix/workflow-permissions-scalar-parse-error branch September 15, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant