Repository navigation
ci: a new triage rule without an sq-map row fails here, at the source - #1127
Merged
Merged
Conversation
A new hypatia/ci_failure_triage rule, or a lost row for one of the two ADR 0004 workflow_audit ids (actions_lock_stale, mirror_without_visibility_guard), now fails this repository's own CI and names the row to add, so the author maps it in the same change. - .github/workflows/sq-map-source-check.yml: on pull_request and push to main, path-filtered to hypatia_rules_praxis.deed, its generator (scripts/gen-rules-praxis.sh) and the sources the generator reads (lib/rules/**, lib/pattern_registry.ex, lib/hypatia/cli.ex, lib/hypatia/scanner_suppression.ex, lib/scorecard_ingestor.ex), plus workflow_dispatch. It sparse-checks out hyperpolymath/proven-cicd-and-workflows at main (public, no token needed) and runs that checkout's tests/registry-sq-map.sh. A failed checkout, generator or test is NOT RUN and fails the job. contents: read, a concurrency group, a 5-minute timeout, no GitHub context inside run:. Not a required check. - scripts/check-sq-map.sh: runs the generator (--stdout) and checks the registry the rule sources emit now, not the committed deed (quality.yml already fails a stale deed). On a failure it prints the exact tab-separated row (<id> unassigned unmapped present <note>) and says to add it in a proven-cicd PR first, then re-run here. - tests/check-sq-map-test.sh: 13 controls (pass, new id with the exact row, the printed row makes it pass, a deleted ADR row, NOT RUN for a missing checkout, test, deed or unreadable registry, generator path). - actions.lock: the new workflow's entry (actions/checkout@v7.0.1, whose record is already in the lock), as gh actions-lock writes it. The proven lock kernel judges the lock CONSISTENT with it and a defect without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The owner asked, through the proven-cicd advisor, for hypatia's own CI to catch a new
ci_failure_triagerule, or one of the two ADR 0004workflow_auditids, that has no row in proven-cicd'sproven/registry/sq-map.tsv. The author then adds the row in the same change. proven-cicd's weekly run stays as a backstop.Changes
.github/workflows/sq-map-source-check.ymlscripts/gen-rules-praxis.sh, every source the generator reads, and the check's own files.main(the map and its test only).mainis used rather than a pin because the question is whether the rule is mapped now.if: failure()step reports it as NOT RUN.contents: read, a concurrency group, a 5-minute timeout, and no${{ }}insiderun:.scripts/check-sq-map.shquality.ymlalready fails a stale committed deed.tests/registry-sq-map.sh.<id>\tunassigned\tunmapped\tpresent\t<note>), says to open a proven-cicd PR first and then re-run here, and separates NOT RUN from a real miss.tests/check-sq-map-test.sh: 13 controls. The job runs them before the check.actions.lock: an entry for the new workflow, reusing the existingactions/checkout@v7.0.1record. The proven lock kernel reports CONSISTENT with the entry and a defect without it.Verification
hypatia_pin_driftandshellcheck_findings. This is the intended behaviour until hyperpolymath/proven-cicd-and-workflowsproven/sq-map-currentmerges.gen-rules-praxis.sh --check,tests/rules-praxis-test.sh(22/22),check-readme-claims.shand the invisible-character scanner all pass.Making this a required check is a ruleset decision for the owner; this PR doesn't do it.
Generated by Claude Code