Repository navigation
ci(estate-rescan): pin panic-attack at cbf2b93, the deed-first reader - #1124
Conversation
panic-attack#295 reads audits/assail-classifications_praxis.deed before the retired .a2ml, so the pinned scanner must include it before this branch drops the .a2ml registry (Codex P1 on this PR). The standards lane moves in metadatastician/standards#1585; hypatia-scan.yml follows that merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 042e09aef2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # panic-ref) and every other lane; owner ruling 2026-11-13. Check with | ||
| # `mix hypatia.ci_triage pins` (scanner_pin_drift, hypatia#1064). | ||
| PA_SHA: 410a8f821ea8297833162565b50a298f787815da | ||
| PA_SHA: cbf2b935ef4260cc3ae66010f4ffc91385ff8f8c |
There was a problem hiding this comment.
Until the planned standards update lands, this creates the scanner-pin drift the adjacent comment forbids: .github/workflows/hypatia-scan.yml:28-31 still calls standards commit 7641c7fd… without overriding panic-ref, and that reusable workflow defaults it to 410a8f82…. Consequently normal Hypatia scans continue using the pre-deed reader and report the 14 audited findings as unsuppressed while estate rescans use cbf2b935…; pass the new panic-ref from the caller or update the reusable-workflow pin atomically.
Useful? React with 👍 / 👎.
|
Summary
#1118 merged before this commit reached it. That PR replaced
audits/assail-classifications.a2mlwithaudits/assail-classifications_praxis.deed. The scanner inestate-rescan.ymlis still pinned at410a8f82, which predates panic-attack's deed reader. Until the pin moves, that lane reads no registry, and the 14 audited findings come back unsuppressed. This was Codex's P1 on #1118.Changes
estate-rescan.yml:PA_SHAmoves from410a8f82…tocbf2b935ef4260cc3ae66010f4ffc91385ff8f8c, the feat(assail): read the user-classification registry as a deed first panic-attack#295 merge commit that holds the deed-first reader.Remaining lane
The standards lane moves in metadatastician/standards#1585. After that, this repo's
hypatia-scan.ymluses:moves to the new standards commit. That step is a reusable-workflow pin, so it goes through the standards pin applier rather than a hand edit.Generated by Claude Code