Skip to content

fix(coverage): keep unknown evidence tag keys as strings #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 2 commits into from
Nov 14, 2026
+9 −0
Merged

fix(coverage): keep unknown evidence tag keys as strings #1122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
444c867
fix(coverage): keep unknown evidence tag keys as strings
claude Nov 14, 2026
fab7cdb
Merge branch 'main' into claude/evidence-formatter-atom
hyperpolymath Nov 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/coverage/evidence_formatter_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,15 @@ defmodule Hypatia.Coverage.EvidenceFormatterTest do
assert counted?(r) == :counted
end

# Hypatia code_safety/elixir_atom_from_user on main after #1107.
test "an unknown string key in the tag does not create an atom" do
key = "zz_evidence_key_#{System.unique_integer([:positive])}"
tag = %{evidence: %{"kind" => "E", key => 1}}
r = EvidenceFormatter.record(test_struct(:"test atom", nil, tag), @cfg)
assert r["kind"] == "E"
assert_raise ArgumentError, fn -> String.to_existing_atom(key) end
end

test "a nested property map and string keys work the same" do
tag = %{
"kind" => "R",
Expand Down
Loading