Repository navigation
Feat(Blog): 增加博客管理页面 - #1220
Feat(Blog): 增加博客管理页面#1220Lirzh wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
WalkthroughThe blog package adds a Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The management list’s pagination and English labels have no established blocking issue; the change is ready to merge after normal checks. Pre-merge checks |
|
There was a problem hiding this comment.
🔇 Additional comments (3)
packages/blog/templates/manage_blog.html (1)
1-44: LGTM!packages/blog/index.ts (2)
269-269: 🎯 Functional CorrectnessThe repository uses
koconsistently.packages/blog/index.tsloads the Korean translations withctx.i18n.load('ko', {, and the corresponding resource ispackages/hydrooj/locales/ko.yaml. The search found nokrloader or locale resource, so this concern is not actionable.
251-252: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Add translations for the new labels in English.
The new keys
No blogs yet.andBlogs per pagehave entries inzh,zh_TWandko. Theenblock has no entries for them. English falls back to the key text, so the output is correct. If the project expects the same keys in every locale, add the entries for consistency.Also applies to: 266-267, 281-282
Source: Learnings
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
12555373-4222-4f97-bc2e-029996c554d9
📒 Files selected for processing (2)
packages/blog/index.tspackages/blog/templates/manage_blog.html
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
|
I have read the CLA Document and I hereby sign the CLA |
Summary by CodeRabbit