fix: pass missing st argument to CIRCLE_send_no_work - #46
Open
EvgeniiIvanov wants to merge 1 commit into
Open
Conversation
CIRCLE_send_work() called CIRCLE_send_no_work(dest) when a single work item exceeded the MPI_Send size limit, but the function's signature is CIRCLE_send_no_work(CIRCLE_state_st* st, int dest). Fix the call site to pass both st and dest, matching the other call sites of this function in the file. Also silence a -Wunused-parameter warning in CIRCLE_workreceipt_check() by explicitly marking the unused qp parameter, which is kept for API symmetry with the sibling function CIRCLE_workreq_check().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CIRCLE_send_work() called CIRCLE_send_no_work(dest) when a single work item exceeded the MPI_Send size limit, but the function's signature is CIRCLE_send_no_work(CIRCLE_state_st* st, int dest). Fix the call site to pass both st and dest, matching the other call sites of this function in the file.
Also silence a -Wunused-parameter warning in
CIRCLE_workreceipt_check() by explicitly marking the unused qp parameter, which is kept for API symmetry with the sibling function CIRCLE_workreq_check().