Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
# `twine check --strict` passes, because it pip-installs a current twine —
# so the failure appears only at upload, after the tag is public.
- name: Publish via Trusted Publishing
uses: pypa/gh-action-pypi-publish@dc37677b2e1c63e2034f94d8a5b11f265b73ba33 # v1.14.2
uses: pypa/gh-action-pypi-publish@7245906fb61fa33a13554f9d5fb856fe61758086 # v1.14.3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Update the pin in scripts/publish-workflow.sh:74 to the same v1.14.3 SHA (not blocking).

scripts/publish-workflow.sh still emits pypa/gh-action-pypi-publish@ed0c5393... # v1.13.0. That version is older than 1.14.2, so the advisory likely applies to it too. Any publish.yml generated from this script reintroduces the vulnerable action. Dependabot does not scan action pins inside a shell heredoc.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 04798d0.


# Announce the release in #deploy. Runs only when the publish above
# succeeded. Posts via the shared Hotdata CI Slack app (bot token), so the
Expand Down
2 changes: 1 addition & 1 deletion scripts/publish-workflow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,5 @@ jobs:
path: dist/

- name: Publish via Trusted Publishing
uses: pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e # v1.13.0
uses: pypa/gh-action-pypi-publish@7245906fb61fa33a13554f9d5fb856fe61758086 # v1.14.3
EOF
Loading