Repository navigation
feat(tables): --layout on tables add, ivf_rebalance_sweep job type, SQL UPDATE/DELETE in the skill - #366
Conversation
…QL UPDATE/DELETE in the skill - databases tables add --layout analytical|point_lookup; tables show reports the layout - jobs list --job-type ivf_rebalance_sweep - skill: SQL UPDATE and DELETE now run (match by rowid, no key needed); list what is still refused Needs hotdata (sdk-rust) 0.21.0 for TableInfo.layout and JobType::IvfRebalanceSweep.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| .collect(); | ||
| crate::output::table::print(&["TABLE", "COLUMN", "DATA_TYPE", "NULLABLE"], &rows); | ||
| use crossterm::style::Stylize; | ||
| eprintln!("{}", format!("layout: {}", out.layout).dark_grey()); |
There was a problem hiding this comment.
nit: Move the layout: line out of the else branch so it prints in both cases (not blocking).
The else branch skips the line for a table with no columns. In that case -o table never shows the layout, but -o json/-o yaml still include it. The PR description says tables show reports the layout.
| "key_determines": key_determines, | ||
| "sorted_by": sorted_by, | ||
| "partition_by": partition_by, | ||
| "layout": layout.unwrap_or("analytical"), |
There was a problem hiding this comment.
nit: Make the JSON output and the table output agree when --layout is omitted (not blocking).
The JSON output reports "analytical" without a --layout flag. The table output at line 1220 prints no layout: line in the same case. The "analytical" value is also the CLI's assumption about the server default. The declare response does not confirm it. Fix: print layout: analytical in the table branch too, or emit null in JSON when the flag is absent.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Catches the CLI up with recent API changes. Bumps the hotdata SDK to 0.21.0.
databases tables add --layout analytical|point_lookup(runtimedb #1661).tables showreports the layout.jobs list --job-type ivf_rebalance_sweep(runtimedb #1598).UPDATEandDELETEnow run (runtimedb #1687, #1695). It now lists what is still refused instead of saying "not supported yet".Tests: 659 pass. Clippy is clean.