Repository navigation
fix: watch managed Argo applications - #4
Conversation
Implements [[tasks/harmony-1397]]
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe application render template now sets ChangesApplication resource watching
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized change enables managed Argo Applications to be recreated promptly after external deletion and adds coverage for the rendered watch setting; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Published Crossplane PackageThe following Crossplane package was published as part of this PR: Package: ghcr.io/hops-ops/gitops-environment:pr-4-18ae227f070db0a39e79d0301d60b756d5cb6e43 |
Summary
Production evidence
During legacy Application adoption, Argo safely pruned the three old parent Applications without cascading to child workloads. The Kubernetes provider Objects had watch disabled, so their cached Ready status did not immediately notice deletion. A one-time managed-resource reconcile restored all three parents; they are now Synced and Healthy under Crossplane ownership, and the Storybook preview remained Healthy throughout.
Verification
Implements [[tasks/harmony-1397]]
Summary by CodeRabbit