[DBX-7194] Feat: Support Metadata for Ref by xuantho573 · Pull Request #989 · holistics/dbml

xuantho573 · 2026-10-05T09:38:32Z

Summary

Short summary of the task, what have been done etc
Please include screenshots whenever possible (important).

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

(Added class EmailValidator to validate email address' validity)
(Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

linear-code · 2026-10-05T09:38:37Z

DBX-7194

github-actions · 2026-10-05T09:40:28Z

Benchmark Result

dbml-parse

suite	🏠 master	🔀 this branch	change
18k	1523.336ms ±3.12%	1550.456ms ±9.54%	⚪ +1.8%
25k	2237.015ms ±5.71%	2334.839ms ±8.11%	⚪ +4.4%

github-actions · 2026-10-06T04:46:24Z

Coverage Report

Commit: a6d174b

Overall Coverage

Metric	Coverage
Lines	✅ 85.55% (9958/11640)
Statements	✅ 82.55% (10841/13132)
Functions	✅ 88.15% (2076/2355)
Branches	⚠️ 73.63% (6537/8878)

Package Coverage

Package	Lines	Statements	Functions	Branches
dbml-cli	✅ 100.00%	✅ 100.00%	✅ 100.00%	✅ 100.00%
dbml-connector	⚠️ 64.62%	⚠️ 64.36%	⚠️ 59.53%	⚠️ 59.09%
dbml-core	N/A	N/A	N/A	N/A
dbml-parse	✅ 87.39%	✅ 84.07%	✅ 90.41%	⚠️ 74.55%

⚠️ Coverage Warnings

The following packages have coverage below 80%:

dbml-connector: 64.62% line coverage

Files with Coverage Below 80%

dbml-connector

9 file(s) below 80% coverage

File	Lines	Statements	Functions	Branches
`src/connectors/bigquery/index.ts`	0.00%	0.00%	0.00%	0.00%
`src/utils/credential-loader.ts`	0.00%	0.00%	0.00%	0.00%
`src/utils/helpers.ts`	0.00%	0.00%	0.00%	0.00%
`src/connectors/snowflake/index.ts`	10.56%	10.31%	0.00%	0.00%
`src/utils/parseSchema.ts`	46.15%	42.85%	28.57%	27.27%
`src/connectors/connector.ts`	66.66%	66.66%	100.00%	57.14%
`src/connectors/oracle/tables.ts`	71.25%	67.39%	100.00%	56.96%
`src/connectors/oracle/index.ts`	80.00%	80.76%	100.00%	25.00%
`src/connectors/oracle/utils.ts`	85.71%	85.71%	100.00%	71.42%

dbml-parse

97 file(s) below 80% coverage

File	Lines	Statements	Functions	Branches
`src/compiler/queries/container/scope.ts`	0.00%	0.00%	0.00%	0.00%
`src/core/global_modules/program/utils/records.ts`	0.00%	0.00%	0.00%	0.00%
`src/services/code_actions/provider.ts`	0.00%	0.00%	0.00%	0.00%
`src/services/diagnostics/provider.ts`	0.00%	0.00%	0.00%	0.00%
`src/compiler/queries/pipeline/interpret.ts`	10.52%	12.19%	66.66%	41.66%
`src/services/suggestions/crossFile.ts`	19.35%	19.44%	33.33%	10.00%
`src/core/local_modules/enum/index.ts`	48.00%	46.29%	57.14%	52.63%
`src/core/global_modules/project/interpret.ts`	52.50%	46.66%	83.33%	23.07%
`src/compiler/queries/legacy/parse.ts`	53.84%	46.66%	50.00%	25.00%
`src/compiler/projectLayout/layout.ts`	59.25%	60.00%	76.92%	60.86%
`src/core/local_modules/dep/index.ts`	59.37%	58.82%	100.00%	53.57%
`src/core/local_modules/ref/index.ts`	62.50%	61.76%	100.00%	57.14%
`src/core/types/report.ts`	62.96%	56.66%	76.92%	57.14%
`src/core/global_modules/records/utils/data/values.ts`	63.30%	55.71%	72.72%	49.28%
`src/compiler/queries/legacy/token.ts`	66.66%	66.66%	66.66%	100.00%
`src/core/global_modules/enum/bind.ts`	66.66%	68.75%	83.33%	50.00%
`src/core/local_modules/program/index.ts`	66.66%	69.23%	75.00%	62.50%
`src/core/types/symbol/symbols.ts`	68.25%	60.32%	63.35%	52.43%
`src/core/global_modules/note/bind.ts`	69.23%	71.42%	83.33%	50.00%
`src/core/local_modules/checks/index.ts`	69.23%	75.00%	100.00%	64.28%
`src/core/local_modules/project/index.ts`	69.23%	69.23%	100.00%	63.63%
`src/core/local_modules/custom/index.ts`	70.58%	71.42%	80.00%	68.75%
`src/compiler/queries/utils.ts`	73.17%	73.43%	84.61%	52.17%
`src/core/global_modules/project/bind.ts`	73.33%	75.00%	100.00%	50.00%
`src/core/local_modules/indexes/index.ts`	73.68%	69.35%	63.63%	64.28%
`src/core/local_modules/tablePartial/validate.ts`	73.91%	73.04%	81.33%	58.42%
`src/core/local_modules/use/index.ts`	73.91%	75.00%	75.00%	78.12%
`src/core/local_modules/indexes/validate.ts`	74.28%	74.66%	90.90%	56.00%
`src/core/local_modules/note/index.ts`	75.00%	75.86%	75.00%	72.72%
`src/core/local_modules/project/validate.ts`	75.86%	75.86%	100.00%	56.25%
`src/core/parser/utils.ts`	76.04%	76.33%	100.00%	81.10%
`src/core/global_modules/indexes/bind.ts`	76.31%	74.35%	90.90%	68.96%
`src/core/global_modules/records/utils/data/sqlTypes.ts`	76.59%	80.64%	82.35%	72.22%
`src/core/local_modules/metadata/index.ts`	77.77%	76.92%	75.00%	75.00%
`src/core/global_modules/tablePartial/interpret.ts`	78.12%	70.90%	78.94%	53.84%
`src/services/suggestions/utils/index.ts`	78.57%	78.57%	100.00%	65.51%
`src/core/types/relation.ts`	79.31%	73.52%	58.33%	80.00%
`src/core/global_modules/tableGroup/bind.ts`	80.00%	80.00%	100.00%	57.14%
`src/core/local_modules/note/validate.ts`	80.00%	79.62%	88.23%	70.58%
`src/core/global_modules/utils.ts`	80.24%	77.27%	72.72%	65.51%
`src/core/types/filepath.ts`	80.48%	79.06%	78.94%	69.56%
`src/core/global_modules/records/utils/constraints/helper.ts`	81.08%	80.48%	82.35%	76.47%
`src/core/global_modules/indexes/interpret.ts`	81.39%	72.00%	100.00%	56.66%
`src/core/local_modules/tablePartial/index.ts`	81.48%	81.48%	100.00%	77.27%
`src/core/local_modules/diagramView/validate.ts`	81.57%	78.04%	84.21%	72.72%
`src/core/local_modules/checks/validate.ts`	81.63%	82.69%	93.75%	70.00%
`src/core/local_modules/records/index.ts`	82.50%	83.33%	100.00%	74.46%
`src/core/global_modules/records/bind.ts`	82.92%	83.72%	93.75%	67.30%
`src/compiler/queries/container/token.ts`	83.33%	85.71%	100.00%	75.00%
`src/core/parser/parser.ts`	83.65%	83.96%	98.50%	75.21%
`src/core/global_modules/ref/bind.ts`	83.87%	83.87%	90.00%	75.00%
`src/core/local_modules/records/validate.ts`	84.14%	84.70%	95.23%	75.36%
`__tests__/utils/compiler.ts`	84.39%	81.91%	100.00%	57.98%
`src/compiler/queries/transform/syncDep.ts`	84.84%	84.21%	100.00%	63.33%
`src/core/local_modules/enum/validate.ts`	85.48%	81.81%	81.25%	76.31%
`__tests__/utils/mocks.ts`	85.71%	86.20%	75.00%	100.00%
`src/compiler/queries/transform/updateElementSetting.ts`	86.79%	86.88%	100.00%	71.92%
`src/core/local_modules/dep/validate.ts`	86.81%	82.00%	93.33%	76.23%
`src/services/suggestions/utils/useMerger.ts`	86.95%	81.13%	100.00%	46.34%
`src/services/suggestions/provider.ts`	87.02%	83.12%	92.85%	76.24%
`src/core/global_modules/tablePartial/bind.ts`	87.03%	87.27%	100.00%	71.42%
`src/services/suggestions/recordRowSnippet.ts`	88.46%	87.09%	100.00%	73.80%
`src/compiler/queries/nodeAtPosition.ts`	88.88%	90.00%	100.00%	75.00%
`src/core/global_modules/diagramView/index.ts`	89.16%	86.23%	83.33%	78.18%
`src/core/global_modules/tableGroup/interpret.ts`	89.58%	89.58%	100.00%	77.27%
`src/core/utils/note.ts`	89.65%	87.14%	100.00%	78.33%
`src/core/types/symbol/metadata.ts`	90.62%	79.26%	95.65%	63.60%
`src/core/global_modules/records/index.ts`	90.90%	87.15%	100.00%	79.16%
`src/compiler/index.ts`	91.11%	91.17%	73.68%	80.00%
`src/core/global_modules/table/index.ts`	91.75%	89.86%	100.00%	77.29%
`src/core/global_modules/schema/index.ts`	92.30%	82.54%	91.66%	70.28%
`src/core/global_modules/table/interpret.ts`	92.68%	84.73%	96.55%	66.66%
`src/core/local_modules/table/validate.ts`	92.77%	93.33%	100.00%	78.48%
`src/core/global_modules/diagramView/interpret.ts`	94.59%	90.40%	92.85%	75.75%
`src/services/suggestions/use.ts`	94.68%	87.61%	100.00%	77.45%
`src/core/global_modules/ref/interpret.ts`	94.82%	93.44%	91.66%	79.31%
`src/core/utils/interpret.ts`	95.89%	92.00%	100.00%	75.64%
`__tests__/examples/interpreter/multifile/utils.ts`	96.00%	89.65%	100.00%	62.50%
`src/core/global_modules/records/interpret.ts`	96.00%	92.63%	100.00%	79.85%
`src/core/global_modules/note/interpret.ts`	96.29%	96.29%	100.00%	75.00%
`src/core/global_modules/metadata/utils.ts`	96.36%	91.30%	100.00%	75.86%
`src/core/global_modules/dep/interpret.ts`	96.93%	92.72%	100.00%	76.19%
`src/compiler/queries/canonicalName.ts`	96.96%	92.10%	100.00%	76.66%
`src/core/global_modules/tableGroup/index.ts`	97.36%	91.30%	100.00%	78.78%
`src/core/global_modules/program/interpret.ts`	97.52%	93.04%	100.00%	71.12%
`src/core/global_modules/records/utils/constraints/pk.ts`	97.61%	92.18%	96.66%	67.85%
`src/compiler/queries/transform/renameTable.ts`	99.05%	90.47%	100.00%	78.82%
`src/compiler/queries/transform/utils/dep.ts`	100.00%	87.50%	100.00%	73.68%
`src/compiler/queries/transform/utils/ref.ts`	100.00%	82.92%	100.00%	64.70%
`src/core/global_modules/checks/interpret.ts`	100.00%	88.88%	100.00%	60.00%
`src/core/global_modules/dep/bind.ts`	100.00%	81.96%	100.00%	73.17%
`src/core/global_modules/metadata/bind.ts`	100.00%	91.66%	100.00%	77.77%
`src/core/global_modules/metadata/index.ts`	100.00%	83.33%	100.00%	75.00%
`src/core/global_modules/metadata/interpret.ts`	100.00%	80.00%	100.00%	58.33%
`src/core/global_modules/records/utils/constraints/unique.ts`	100.00%	93.75%	100.00%	50.00%
`src/core/utils/diagnostics_reporter/ref.ts`	100.00%	100.00%	100.00%	70.83%
`src/services/definition/provider.ts`	100.00%	95.23%	100.00%	71.42%

xuantho573 force-pushed the feat/support-metadata-for-ref branch 7 times, most recently from 9cee52d to bba9796 Compare October 6, 2026 10:05

xuantho573 marked this pull request as ready for review October 6, 2026 10:06

xuantho573 force-pushed the feat/support-metadata-for-ref branch 5 times, most recently from 7fa4618 to 3069bc1 Compare October 12, 2026 09:18

xuantho573 added 5 commits October 13, 2026 10:33

feat: support metadata for ref

63e19fa

chore: improve ref lookup

aa2bbcd

fix: incorrect metadata resolving for ref

b095015

v10.4.0-alpha.0

1f029e0

chore: support note as builtin metadata for ref

2f2d0a2

xuantho573 force-pushed the feat/support-metadata-for-ref branch from 13d120e to 5aa9047 Compare October 13, 2026 03:34

fix: update test after merging master

a9b63af

xuantho573 force-pushed the feat/support-metadata-for-ref branch from 5aa9047 to a9b63af Compare October 13, 2026 09:22

v10.4.0-alpha.1

2abacb4

Navigation Menu

Repository navigation

[DBX-7194] Feat: Support Metadata for Ref - #989

[DBX-7194] Feat: Support Metadata for Ref#989
xuantho573 wants to merge 7 commits into
masterfrom
feat/support-metadata-for-ref

xuantho573 commented Oct 5, 2026

Uh oh!

linear-code Bot commented Oct 5, 2026

Uh oh!

github-actions Bot commented Oct 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 6, 2026 •

edited

Loading

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

xuantho573 commented Oct 5, 2026

Summary

Issue

Lasting Changes (Technical)

Checklist

Uh oh!

linear-code Bot commented Oct 5, 2026

Uh oh!

github-actions Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Result

dbml-parse

Uh oh!

github-actions Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Overall Coverage

Package Coverage

⚠️ Coverage Warnings

Files with Coverage Below 80%

dbml-connector

dbml-parse

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Oct 5, 2026 •

edited

Loading

github-actions Bot commented Oct 6, 2026 •

edited

Loading