fix(eol): declare the federation key on the catalog remediation type - #36
Merged
Merged
Conversation
NesRemediation omitted the target the scan service emits and every gateway client can select, so it disagreed with the schema and the service model. Add target as optional, since a GraphQL client receives it only when it selects it, and document that the scan service emits only the key while the catalog subgraph owns and resolves the remediations. A type-level spec pins the shape.
facundo-herodevs
marked this pull request as ready for review
September 29, 2026 16:16
jeremymwells
approved these changes
Sep 29, 2026
v3nant
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Branch Does
Declares the federation key on
NesRemediation, the catalog remediation type attached to a scan component.target?: string. The scan service emits only this key; the catalog subgraph owns and resolvesremediations.targetis optional because a GraphQL client receives it only when it selects it. Clients that select onlyremediationskeep type-checking unchanged.Test Coverage
NesRemediation['target']tostring | undefinedandEolScanComponent['nesRemediation']toNesRemediation | null | undefined.Known Gaps
remediationsitem shape still declares non-nullpurls.nesandurls.main, while the catalog fields are nullable. That is unchanged here.Refs neverendingsupport/evergreen-ui#427