Repository navigation
feat: let ad-hoc chart dependencies override their condition - #214
Merged
Merged
Conversation
- ChartDependency gains an optional Condition, written to the dependency's `condition` in the generated Chart.yaml. Left empty, it keeps the current `<alias or chart name>.enabled`, so existing callers see no change. - A test covers an aliased local dependency with an explicit condition. Signed-off-by: Cayan <1619617+Cayan@users.noreply.github.com>
Signed-off-by: Cayan <1619617+Cayan@users.noreply.github.com>
Exercise ChartDependency.Condition through the full chartify pipeline (UpdateRequirements writes it to Chart.yaml, helm template evaluates it) so the new override is proven beyond ReadAdhocDependencies unit tests. The rendered snapshots match the default-condition cases because neither the db nor the log test chart references .Values.global. Signed-off-by: yxxhero <aiopsclub@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part A of helmfile/helmfile#1258.
ChartDependencygets an optionalCondition. It is written to the dependency'sconditionin the generatedChart.yaml; when it is empty, the current<alias or chart name>.enabledis kept, so nothing changes for existing callers.The new case in
TestReadAdhocDependenciesuses an aliased local chart withCondition: "global.mydb.enabled"; it fails without the change. The existing case already covers the default.Part B will add
conditionto the releasedependencies:in helmfile and bump chartify once this is released.