Skip to content

test: give the outcome deadline test its whole deadline #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hellices merged 1 commit into from
Oct 29, 2026
Merged

test: give the outcome deadline test its whole deadline #512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/ui/test_deployment_outcome_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,12 @@ async def snapshot(self, namespace: str, name: str) -> RawDeploymentOutcomeSnaps
reaped.set()
raise AssertionError("unreachable")

controller, ui = _controller(HungReader(), deadline_seconds=0.01)
# A frozen clock gives the run its whole deadline however late its worker
# starts (#511): with the real one, a runner slower than the deadline
# marked it elapsed before the reader was ever called. The deadline is
# still enforced by the run's real asyncio timeout, so it must outlast the
# read task's start on a coarse Windows timer.
controller, ui = _controller(HungReader(), deadline_seconds=0.5, clock=lambda: 0.0)
observer = controller.scale_observer(
epoch=4,
namespace="default",
Expand Down
Loading