Repository navigation
Added hed-tests as a submodule - #899
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The missing submodule gitlink prevents checkout and causes the new specification runner to fail.
1 open finding
What changed in this PR
Migrates specification tests to the official hed-tests suite, though the required submodule gitlink is missing.
Changes:
- Replaces the legacy JSON runner with a submodule-based runner.
- Documents setup, schema loading, and skipped cases.
- Updates Jest and CI configuration for submodules.
| File | Description |
|---|---|
.gitmodules |
Declares the hed-tests submodule. |
.github/workflows/tests.yml |
Enables submodule checkout for spec tests. |
.github/workflows/coverage.yml |
Enables submodule checkout for coverage. |
spec_tests/hedTests.spec.js |
Runs official validation cases. |
spec_tests/skippedTests.js |
Records unsupported cases. |
spec_tests/jsonTests.spec.js |
Removes the legacy runner. |
spec_tests/README.md |
Documents the new suite. |
README.md |
Adds test setup instructions. |
jest.config.js |
Ignores tests inside the submodule. |
CHANGELOG.md |
Records the migration. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.