Skip to content

Add regression tests and fix for registering names against dead PIDs - #499

Merged
LaurentRDC merged 1 commit into
haskell-distributed:masterfrom
hyperthunk:reg-name-monitors
Nov 3, 2026
Merged

LaurentRDC merged 1 commit into
haskell-distributed:masterfrom
hyperthunk:reg-name-monitors

Conversation

@hyperthunk

Copy link
Copy Markdown
Member

Notify the remote registry immediately when a newly registered local process is already dead, since no later death notification will arrive.

Two failing test cases for registering names against dead pids, plus regression for registering already-dead remote processes through local and remote registries (#212).

Includes a control case confirming name removal when a live remote process dies after registration.

Notify the remote registry immediately when a newly registered local process is already dead, since no later death notification will arrive.

Two failing test cases for registering names against dead pids, plus regression for registering already-dead remote processes through local and remote registries (haskell-distributed#212).

Includes a control case confirming name removal when a live remote process dies after registration.

@LaurentRDC LaurentRDC left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LaurentRDC

Copy link
Copy Markdown
Member

CI failure is an unrelated flaky test

@LaurentRDC

Copy link
Copy Markdown
Member

@hyperthunk Could you add a changelog entry for future version 0.7.11?

@hyperthunk

Copy link
Copy Markdown
Member Author

add a changelog entry for future version 0.7.11?

Absolutely! I'll get that done and add the commit to this PR.

@hyperthunk

Copy link
Copy Markdown
Member Author

add a changelog entry for future version 0.7.11?

Absolutely! I'll get that done and add the commit to this PR.

I got a bit delayed on this. Where is your changelog @LaurentRDC, there are no instructions for this in the contributing guide.

@LaurentRDC

Copy link
Copy Markdown
Member

The changelog for each package (if one exists, which there isn't for distributed-process-tests) is alongside the cabal file. So there's one at packages/distributed-process/ChangeLog.

Don't worry about it. I'll update the contributor's guide, and I can add the changelog entry for this PR.

@hyperthunk

Copy link
Copy Markdown
Member Author

The changelog for each package (if one exists, which there isn't for distributed-process-tests) is alongside the cabal file. So there's one at packages/distributed-process/ChangeLog.

Don't worry about it. I'll update the contributor's guide, and I can add the changelog entry for this PR.

Okay thanks @LaurentRDC , and duly noted for next PR!

@LaurentRDC
LaurentRDC merged commit f967c68 into haskell-distributed:master Nov 3, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants