Skip to content

fix: get diffview layout dynamically - #595

Merged
jakubbortlik merged 1 commit into
developfrom
fix/reviewer-autocommands
Oct 14, 2026
Merged

jakubbortlik merged 1 commit into
developfrom
fix/reviewer-autocommands

Conversation

@jakubbortlik

Copy link
Copy Markdown
Collaborator

Current Diffview layout must be selected dynamically, not once when Diffview is started, otherwise switching layouts breaks reviewer keymaps.

This PR fixes two issues:

  • switching Diffview layouts in the reviewer broke keymaps and buffer-local options (modifiable)
  • switching layouts caused comments being placed on the wrong file

Comment thread lua/gitlab/reviewer/init.lua Outdated
Comment thread lua/gitlab/reviewer/init.lua Outdated
@jakubbortlik
jakubbortlik force-pushed the fix/reviewer-autocommands branch from 0213194 to 089911a Compare October 12, 2026 04:18
Current Diffview layout must be selected dynamically, not once when
Diffview is started, otherwise switching layouts breaks reviewer
keymaps.
@jakubbortlik
jakubbortlik force-pushed the fix/reviewer-autocommands branch from 089911a to a20d60b Compare October 14, 2026 04:30
@jakubbortlik
jakubbortlik merged commit 0228b3b into develop Oct 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant