Repository navigation
Exit with an error code when code generation fails - #61
Merged
Merged
Conversation
Generate commands now exit with code 1 when code generation reports errors, with the errors printed by the same handler as every other error. The verify command prints the device metadata path only after the file has loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate commands now exit with code 1 when code generation reports errors, where they previously printed the errors and exited with code 0.
AssertNoGeneratorErrorsthrows with the error log as its description, so the errors are printed by the top-level handler like every other failure. Generation still continues when there are only warnings.The
verifycommand prints the device metadata path only after the file has loaded. This replaces a progress line that stayed open while the file loaded, so a metadata error now starts on its own line.