Repository navigation
Report device metadata validation errors - #58
Merged
Merged
Conversation
Harp.Generators 0.9.0 now validates device metadata when it is loaded. Errors in a metadata file are reported with the path of the file, and with the line and column for syntax errors. All errors, including unexpected exceptions with their stack trace, are reported by a single handler at the top level. Generated Bonsai operators no longer include the device name in their label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harp.Generators0.9.0 now validates device metadata when it is loaded, see harp-tech/generators/v0.9.0. The toolkit reports all errors in metadata files with the path of the file, including the line and column for YAML syntax errors.All errors are reported by a single handler in
Main. The code that loads a metadata file or opens a serial port adds a description to any exception it does not handle, and the handler prints that description, or the full exception when there is none. The root command moves into its ownToolkitCommandclass, and theverify --metadataoption into its ownMetadataPathOptionclass.Device metadata that loaded with 0.8.0 may now be refused, most often because an omitted default value counts as zero and is below the declared minimum.