Repository navigation
Add IP location display for comments and replies - #262
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in setting to display IP locations for comments and replies before
their timestamps. Locations use province-level labels for mainland China and
country or region labels elsewhere. Missing locations display “Unknown”.
Resolve new comments and replies asynchronously, and backfill existing records
in batches when enabled. Lookups run offline using bundled IPv4 and IPv6
ip2region databases, reduced to country, province, and country code fields.
Location labels are persisted as annotations. Disabling the setting hides them
in the widget but does not remove existing annotations from public responses.
Raw IP addresses are not copied into annotations, and stored locations are not
automatically rewritten when the database changes.
Validation:
country, province, and country code after database reduction.
Accuracy remains dependent on the bundled upstream dataset. External checks
found discrepancies on cloud and enterprise networks; these checks do not
establish accuracy for residential or mobile networks.